[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: [developer] Review Request 1057: 9415 bnxe: this statement may fall through
From: Toomas Soome <tsoome () me ! com>
Date: 2018-03-28 20:11:22
Message-ID: 26CCC280-508F-4E47-A52E-A4147572F79C () me ! com
[Download RAW message or body]
hi!
please review. This patch is special one. Special in sense that it last issue listed \
up in my gcc 7 branch for problems noted by gcc 7 build.
thanks,
toomas
> Begin forwarded message:
>
> From: Toomas Soome <tsoome@illumos.org>
> Subject: Review Request 1057: 9415 bnxe: this statement may fall through
> Date: 28 March 2018 at 23:09:44 EEST
> To: Joshua Clulow <josh@sysmgr.org>, Vitaliy Gusev <gusev.vitaliy@icloud.com>, \
> Marcel Telka <marcel@telka.sk>, Andy Fiddaman <af@citrus-it.net>, Toomas Soome \
> <tsoome@me.com>, Yuri Pankov <yuripv@yuripv.net>, Albert Lee <trisk@nexenta.com>, \
> Juraj Lutter <juraj@lutter.sk>, Dan Vatca <dan@syneto.net>, John Howard \
> <Echosoft.LLC@gmail.com>, Norm Jacobs <naj@snapcon.com>
> Reply-To: Toomas Soome <tsoome@illumos.org>
>
> This is an automatically generated e-mail. To reply, visit: \
> https://www.illumos.org/rb/r/1057/ <https://www.illumos.org/rb/r/1057/> Review \
> request for general. By Toomas Soome.
> Bugs: 9415 <https://www.illumos.org/issues/9415>
> Repository: illumos-gate
> Description
>
> ../../common/io/bnxe/577xx/common/bnxe_clc.c:7024:6: error: this statement may fall \
> through [-Werror=implicit-fallthrough=] if (!vars->link_up)
> ^
> ../../common/io/bnxe/577xx/common/bnxe_clc.c:7026:2: note: here
> case ELINK_LED_MODE_ON:
> ^~~~
> ../../common/io/bnxe/577xx/common/bnxe_clc.c: In function 'elink_phy_def_cfg':
> ../../common/io/bnxe/577xx/common/bnxe_clc.c:13311:19: error: this statement may \
> fall through [-Werror=implicit-fallthrough=] phy->req_duplex = DUPLEX_HALF;
> ../../common/io/bnxe/577xx/common/bnxe_clc.c:13312:2: note: here
> case PORT_FEATURE_LINK_SPEED_10M_FULL:
> ^~~~
> ../../common/io/bnxe/577xx/common/bnxe_clc.c:13316:19: error: this statement may \
> fall through [-Werror=implicit-fallthrough=] phy->req_duplex = DUPLEX_HALF;
> ../../common/io/bnxe/577xx/common/bnxe_clc.c:13317:2: note: here
> case PORT_FEATURE_LINK_SPEED_100M_FULL:
> ^~~~
>
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c: In function \
> 'lm_chip_init':
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4615:12: \
> error: this statement may fall through [-Werror=implicit-fallthrough=] if \
> (LM_STATUS_SUCCESS != lm_status) ^
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4619:5: \
> note: here case LM_LOADER_RESPONSE_LOAD_COMMON:
> ^~~~
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4637:9: \
> error: this statement may fall through [-Werror=implicit-fallthrough=] \
> lm_init_intmem_common(pdev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4647:5: \
> note: here case LM_LOADER_RESPONSE_LOAD_PORT:
> ^~~~
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4673:9: \
> error: this statement may fall through [-Werror=implicit-fallthrough=] \
> lm_init_intmem_port(pdev); ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4676:5: \
> note: here case LM_LOADER_RESPONSE_LOAD_FUNCTION:
> ^~~~
>
> In file included from \
> ../../common/io/bnxe/577xx/drivers/common/lm/include/lm5710.h:76:0, from \
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c:37:
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c: In function \
> 'lm_clear_chain_sb_cons_idx':
> ../../common/io/bnxe/577xx/drivers/common/include/debug.h:321:12: error: this \
> statement may fall through [-Werror=implicit-fallthrough=] if (_c) \
> \ ^
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c:112:9: note: in \
> expansion of macro 'DbgBreakIfAll' DbgBreakIfAll(rd_val_32 != 0);
> ^
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c:114:5: note: here
> case STATUS_BLOCK_NORMAL_TYPE:
> ^~~~
>
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c: In function \
> 'lm_get_shmem_mf_mac_info':
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c:2341:60: error: \
> this statement may fall through [-Werror=implicit-fallthrough=] if ( \
> CHIP_IS_E1x(pdev) || IS_SD_UFP_MODE(pdev) || IS_SD_BD_MODE(pdev))
> ../../common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c:2349:5: note: here
> case MULTI_FUNCTION_SI:
> ^~~~
>
> ../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c: In function \
> 'ecore_mcast_validate_e2':
> ../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3391:3: error: \
> this statement may fall through [-Werror=implicit-fallthrough=] \
> o->set_registry_size(o, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3395:2: note: here
> case ECORE_MCAST_CMD_RESTORE:
> ^~~~
> ../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c: In function \
> 'ecore_mcast_validate_e1':
> ../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3697:3: error: \
> this statement may fall through [-Werror=implicit-fallthrough=] \
> o->set_registry_size(o, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3701:2: note: here
> case ECORE_MCAST_CMD_RESTORE:
> ^~~~
>
> ../../common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c: In function \
> 'lm_sc_service_eq_intr':
> ../../common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c:1717:13: error: this \
> statement may fall through [-Werror=implicit-fallthrough=] \
> lm_sc_handle_tcp_event(pdev, cid, kcqe->op_code); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c:1719:9: note: here
> default:
> ^~~~~~~
>
> cc1: all warnings being treated as errors
> Diffs
>
> usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c \
> (0caaff759e5dadf7c8d7fd6a2adb5211303becc1) \
> usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c \
> (4b5fd815d44e42659265b15422c183fcee1d84e8) \
> usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c \
> (1410de16fdab35ccbdbe3990e130a84c6b10f67e) \
> usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c \
> (adbc4b31ecdc1137e7bdf317507cbbf38c16bbf1) \
> usr/src/uts/common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c \
> (1ba65a2510098c370a5164b4b35136eaacf03e4d) \
> usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c \
> (f22f25c84282e9bd70a139cbfc4582575750a8fb) View Diff \
> <https://www.illumos.org/rb/r/1057/diff/1/>
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/discussions/T25962f681587792b-Mb465f6891eee7239fd366f66
Delivery options: https://illumos.topicbox.com/groups
[Attachment #3 (unknown)]
<html><html><html><head><meta content="text/html; charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; line-break: after-white-space;">hi!<div class=""><br \
class="" /></div><div class="">please review. This patch is special one. Special in \
sense that it last issue listed up in my gcc 7 branch for problems noted by gcc 7 \
build.</div><div class=""><br class="" /></div><div class="">thanks,</div><div \
class="">toomas<br class="" /><div><br class="" /><blockquote class="" \
type="cite"><div class="">Begin forwarded message:</div><br \
class="Apple-interchange-newline" /><div class="" style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; \
color:rgba(0, 0, 0, 1.0);"><b class="">From: </b></span><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Toomas Soome <<a class="" \
href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Subject: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;"><b class="">Review \
Request 1057: 9415 bnxe: this statement may fall through</b><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Date: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">28 March 2018 at \
23:09:44 EEST<br class="" /></span></div><div class="" style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; \
color:rgba(0, 0, 0, 1.0);"><b class="">To: </b></span><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Joshua Clulow <<a class="" \
href="mailto:josh@sysmgr.org">josh@sysmgr.org</a>>, Vitaliy Gusev <<a class="" \
href="mailto:gusev.vitaliy@icloud.com">gusev.vitaliy@icloud.com</a>>, Marcel Telka \
<<a class="" href="mailto:marcel@telka.sk">marcel@telka.sk</a>>, Andy Fiddaman \
<<a class="" href="mailto:af@citrus-it.net">af@citrus-it.net</a>>, Toomas Soome \
<<a class="" href="mailto:tsoome@me.com">tsoome@me.com</a>>, Yuri Pankov <<a \
class="" href="mailto:yuripv@yuripv.net">yuripv@yuripv.net</a>>, Albert Lee <<a \
class="" href="mailto:trisk@nexenta.com">trisk@nexenta.com</a>>, Juraj Lutter \
<<a class="" href="mailto:juraj@lutter.sk">juraj@lutter.sk</a>>, Dan Vatca \
<<a class="" href="mailto:dan@syneto.net">dan@syneto.net</a>>, John Howard \
<<a class="" href="mailto:Echosoft.LLC@gmail.com">Echosoft.LLC@gmail.com</a>>, \
Norm Jacobs <<a class="" href="mailto:naj@snapcon.com">naj@snapcon.com</a>><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Reply-To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Toomas Soome <<a \
class="" href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><br class="" /><div class=""><div class=""><div class="" \
style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"><table bgcolor="#f9f3c9" \
cellpadding="12" class="" style="border: 1px #c9c399 solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;" width="100%"><tbody \
class=""><tr class=""><td class=""> This is an automatically generated e-mail. To \
reply, visit: <a class="" \
href="https://www.illumos.org/rb/r/1057/">https://www.illumos.org/rb/r/1057/</a></td></tr></tbody></table><br \
class="" /><table bgcolor="#fefadf" cellpadding="12" cellspacing="0" class="" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;" width="100%"><tbody class=""><tr class=""><td \
class=""><div class="">Review request for general.</div><div class="">By Toomas \
Soome.</div><div class="" style="margin-top: 1.5em;"><strong class="" style="color: \
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a class="" href="https://www.illumos.org/issues/9415">9415</a></div><div class="" \
style="margin-top: 1.5em;"><strong class="" style="color: #575012; font-size: \
10pt;">Repository: </strong> illumos-gate
</div><h1 class="" style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Description </h1><table bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
class="" style="border: 1px solid #b8b5a0" width="100%"><tbody class=""><tr \
class=""><td class=""><pre class="" style="margin: 0; padding: 0; white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: \
break-word;">../../common/io/bnxe/577xx/common/bnxe_clc.c:7024:6: error: this \
statement may fall through [-Werror=implicit-fallthrough=] if (!vars->link_up)
^
../../common/io/bnxe/577xx/common/bnxe_clc.c:7026:2: note: here
case ELINK_LED_MODE_ON:
^~~~
../../common/io/bnxe/577xx/common/bnxe_clc.c: In function \
'elink_phy_def_cfg':
../../common/io/bnxe/577xx/common/bnxe_clc.c:13311:19: error: this statement may fall \
through [-Werror=implicit-fallthrough=] phy->req_duplex = DUPLEX_HALF;
../../common/io/bnxe/577xx/common/bnxe_clc.c:13312:2: note: here
case PORT_FEATURE_LINK_SPEED_10M_FULL:
^~~~
../../common/io/bnxe/577xx/common/bnxe_clc.c:13316:19: error: this statement may fall \
through [-Werror=implicit-fallthrough=] phy->req_duplex = DUPLEX_HALF;
../../common/io/bnxe/577xx/common/bnxe_clc.c:13317:2: note: here
case PORT_FEATURE_LINK_SPEED_100M_FULL:
^~~~
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c: In function \
'lm_chip_init':
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4615:12: \
error: this statement may fall through [-Werror=implicit-fallthrough=] if \
(LM_STATUS_SUCCESS != lm_status) ^
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4619:5: note: \
here case LM_LOADER_RESPONSE_LOAD_COMMON:
^~~~
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4637:9: error: \
this statement may fall through [-Werror=implicit-fallthrough=] \
lm_init_intmem_common(pdev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4647:5: note: \
here case LM_LOADER_RESPONSE_LOAD_PORT:
^~~~
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4673:9: error: \
this statement may fall through [-Werror=implicit-fallthrough=] \
lm_init_intmem_port(pdev); ^~~~~~~~~~~~~~~~~~~~~~~~~
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:4676:5: note: \
here case LM_LOADER_RESPONSE_LOAD_FUNCTION:
^~~~
In file included from \
../../common/io/bnxe/577xx/drivers/common/lm/include/lm5710.h:76:0,
from \
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c:37:
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c: In function \
'lm_clear_chain_sb_cons_idx':
../../common/io/bnxe/577xx/drivers/common/include/debug.h:321:12: error: this \
statement may fall through [-Werror=implicit-fallthrough=]
if (_c) \
^
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c:112:9: note: in \
expansion of macro 'DbgBreakIfAll' DbgBreakIfAll(rd_val_32 != 0);
^
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c:114:5: note: here
case STATUS_BLOCK_NORMAL_TYPE:
^~~~
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c: In function \
'lm_get_shmem_mf_mac_info':
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c:2341:60: error: this \
statement may fall through [-Werror=implicit-fallthrough=]
if ( CHIP_IS_E1x(pdev) || IS_SD_UFP_MODE(pdev) || IS_SD_BD_MODE(pdev))
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c:2349:5: note: here
case MULTI_FUNCTION_SI:
^~~~
../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c: In function \
'ecore_mcast_validate_e2':
../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3391:3: error: this \
statement may fall through [-Werror=implicit-fallthrough=] \
o->set_registry_size(o, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~
../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3395:2: note: here
case ECORE_MCAST_CMD_RESTORE:
^~~~
../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c: In function \
'ecore_mcast_validate_e1':
../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3697:3: error: this \
statement may fall through [-Werror=implicit-fallthrough=] \
o->set_registry_size(o, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~
../../common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c:3701:2: note: here
case ECORE_MCAST_CMD_RESTORE:
^~~~
../../common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c: In function \
'lm_sc_service_eq_intr':
../../common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c:1717:13: error: this \
statement may fall through [-Werror=implicit-fallthrough=] \
lm_sc_handle_tcp_event(pdev, cid, kcqe->op_code); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c:1719:9: note: here
default:
^~~~~~~
cc1: all warnings being treated as errors</pre></td></tr></tbody></table><h1 class="" \
style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1><ul class="" \
style="margin-left: 3em; padding-left: 0;"><li \
class="">usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c <span class="" \
style="color: grey">(0caaff759e5dadf7c8d7fd6a2adb5211303becc1)</span><li \
class="">usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c <span \
class="" style="color: grey">(4b5fd815d44e42659265b15422c183fcee1d84e8)</span><li \
class="">usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c \
<span class="" style="color: \
grey">(1410de16fdab35ccbdbe3990e130a84c6b10f67e)</span><li \
class="">usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c <span \
class="" style="color: grey">(adbc4b31ecdc1137e7bdf317507cbbf38c16bbf1)</span><li \
class="">usr/src/uts/common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c <span \
class="" style="color: grey">(1ba65a2510098c370a5164b4b35136eaacf03e4d)</span><li \
class="">usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c <span class="" \
style="color: grey">(f22f25c84282e9bd70a139cbfc4582575750a8fb)</span></ul><p \
class=""><a class="" href="https://www.illumos.org/rb/r/1057/diff/1/" \
style="margin-left: 3em;">View \
Diff</a></td></tr></tbody></table></div></div></div></blockquote></div><br class="" \
/></div><div id="topicbox-footer" style="margin:10px 0 0;border-top:1px solid \
#ddd;border-color:rgba(0,0,0,.15);padding:7px 0;">
<strong><a href="https://illumos.topicbox.com/latest" \
style="color:inherit;text-decoration:none">illumos</a></strong> /
<a href="https://illumos.topicbox.com/groups/developer/members">illumos-developer</a>
/
<a href="https://illumos.topicbox.com/groups/developer/discussions/T25962f681587792b-Mb465f6891eee7239fd366f66">Permalink</a>
<a href="https://illumos.topicbox.com/groups" style="float:right">Delivery \
options</a> </div>
</body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic