[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: [developer] Review Request 1039: 9396 devfsadm: this statement may fall through
From: Toomas Soome <tsoome () me ! com>
Date: 2018-03-28 9:08:02
Message-ID: 66906F35-9DA7-4D35-B897-1BB52F829215 () me ! com
[Download RAW message or body]
hi!
Please review.
thanks,
toomas
> Begin forwarded message:
>
> From: Toomas Soome <tsoome@illumos.org>
> Subject: Review Request 1039: 9396 devfsadm: this statement may fall through
> Date: 28 March 2018 at 12:07:31 EEST
> To: Joshua Clulow <josh@sysmgr.org>, Vitaliy Gusev <gusev.vitaliy@icloud.com>, \
> Marcel Telka <marcel@telka.sk>, Andy Fiddaman <af@citrus-it.net>, Toomas Soome \
> <tsoome@me.com>, Yuri Pankov <yuripv@yuripv.net>, Albert Lee <trisk@nexenta.com>, \
> Juraj Lutter <juraj@lutter.sk>, Dan Vatca <dan@syneto.net>, John Howard \
> <Echosoft.LLC@gmail.com>, Norm Jacobs <naj@snapcon.com>
> Reply-To: Toomas Soome <tsoome@illumos.org>
>
> This is an automatically generated e-mail. To reply, visit: \
> https://www.illumos.org/rb/r/1039/ <https://www.illumos.org/rb/r/1039/> Review \
> request for general. By Toomas Soome.
> Bugs: 9396 <https://www.illumos.org/issues/9396>
> Repository: illumos-gate
> Description
>
> ../devfsadm.c:6310:14: error: comparison between pointer and zero character \
> constant [-Werror=pointer-compare] if (*p_link == '\0') {
> ^~
> ../devfsadm.c:6310:6: note: did you mean to dereference the pointer?
> if (*p_link == '\0') {
> ^
> ../devfsadm.c: In function 'create_link_common':
> ../devfsadm.c:2802:6: error: this statement may fall through \
> [-Werror=implicit-fallthrough=] s_unlink(devlink);
> ^~~~~~~~~~~~~~~~~
> ../devfsadm.c:2803:5: note: here
> default:
> ^~~~~~~
>
> ../devalloc.c:144:6: error: this statement may fall through \
> [-Werror=implicit-fallthrough=] if (execl(MKDEVALLOC, MKDEVALLOC, DA_IS_LABELED, \
> NULL) == -1) ^
> ../devalloc.c:146:2: note: here
> default:
> ^~~~~~~
>
> cc1: all warnings being treated as errors
> Diffs
>
> usr/src/cmd/devfsadm/devfsadm.c (6f2706c21a722e9d1eecdecf97498fe6fbc33bdf)
> usr/src/cmd/devfsadm/devalloc.c (11147269cb22a5d9659511bccac62469e80b1c75)
> View Diff <https://www.illumos.org/rb/r/1039/diff/1/>
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/discussions/Te4d4ba8fecfdf60b-M7527636ee794fd19121ed17a
Delivery options: https://illumos.topicbox.com/groups
[Attachment #3 (unknown)]
<html><html><html><head><meta content="text/html; charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; line-break: after-white-space;">hi!<div class=""><br \
class="" /></div><div class="">Please review.</div><div class=""><br class="" \
/></div><div class="">thanks,</div><div class="">toomas<br class="" /><div><br \
class="" /><blockquote class="" type="cite"><div class="">Begin forwarded \
message:</div><br class="Apple-interchange-newline" /><div class="" \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: \
0px;"><span class="" style="font-family: -webkit-system-font, Helvetica Neue, \
Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);"><b class="">From: </b></span><span \
class="" style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Toomas Soome <<a class="" \
href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Subject: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;"><b class="">Review \
Request 1039: 9396 devfsadm: this statement may fall through</b><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Date: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">28 March 2018 at \
12:07:31 EEST<br class="" /></span></div><div class="" style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; \
color:rgba(0, 0, 0, 1.0);"><b class="">To: </b></span><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Joshua Clulow <<a class="" \
href="mailto:josh@sysmgr.org">josh@sysmgr.org</a>>, Vitaliy Gusev <<a class="" \
href="mailto:gusev.vitaliy@icloud.com">gusev.vitaliy@icloud.com</a>>, Marcel Telka \
<<a class="" href="mailto:marcel@telka.sk">marcel@telka.sk</a>>, Andy Fiddaman \
<<a class="" href="mailto:af@citrus-it.net">af@citrus-it.net</a>>, Toomas Soome \
<<a class="" href="mailto:tsoome@me.com">tsoome@me.com</a>>, Yuri Pankov <<a \
class="" href="mailto:yuripv@yuripv.net">yuripv@yuripv.net</a>>, Albert Lee <<a \
class="" href="mailto:trisk@nexenta.com">trisk@nexenta.com</a>>, Juraj Lutter \
<<a class="" href="mailto:juraj@lutter.sk">juraj@lutter.sk</a>>, Dan Vatca \
<<a class="" href="mailto:dan@syneto.net">dan@syneto.net</a>>, John Howard \
<<a class="" href="mailto:Echosoft.LLC@gmail.com">Echosoft.LLC@gmail.com</a>>, \
Norm Jacobs <<a class="" href="mailto:naj@snapcon.com">naj@snapcon.com</a>><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Reply-To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Toomas Soome <<a \
class="" href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><br class="" /><div class=""><div class=""><div class="" \
style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"><table bgcolor="#f9f3c9" \
cellpadding="12" class="" style="border: 1px #c9c399 solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;" width="100%"><tbody \
class=""><tr class=""><td class=""> This is an automatically generated e-mail. To \
reply, visit: <a class="" \
href="https://www.illumos.org/rb/r/1039/">https://www.illumos.org/rb/r/1039/</a></td></tr></tbody></table><br \
class="" /><table bgcolor="#fefadf" cellpadding="12" cellspacing="0" class="" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;" width="100%"><tbody class=""><tr class=""><td \
class=""><div class="">Review request for general.</div><div class="">By Toomas \
Soome.</div><div class="" style="margin-top: 1.5em;"><strong class="" style="color: \
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a class="" href="https://www.illumos.org/issues/9396">9396</a></div><div class="" \
style="margin-top: 1.5em;"><strong class="" style="color: #575012; font-size: \
10pt;">Repository: </strong> illumos-gate
</div><h1 class="" style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Description </h1><table bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
class="" style="border: 1px solid #b8b5a0" width="100%"><tbody class=""><tr \
class=""><td class=""><pre class="" style="margin: 0; padding: 0; white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">../devfsadm.c:6310:14: error: comparison between \
pointer and zero character constant [-Werror=pointer-compare] if (*p_link == \
'\0') { ^~
../devfsadm.c:6310:6: note: did you mean to dereference the pointer?
if (*p_link == '\0') {
^
../devfsadm.c: In function 'create_link_common':
../devfsadm.c:2802:6: error: this statement may fall through \
[-Werror=implicit-fallthrough=] s_unlink(devlink);
^~~~~~~~~~~~~~~~~
../devfsadm.c:2803:5: note: here
default:
^~~~~~~
../devalloc.c:144:6: error: this statement may fall through \
[-Werror=implicit-fallthrough=] if (execl(MKDEVALLOC, MKDEVALLOC, DA_IS_LABELED, \
NULL) == -1) ^
../devalloc.c:146:2: note: here
default:
^~~~~~~
cc1: all warnings being treated as errors</pre></td></tr></tbody></table><h1 class="" \
style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1><ul class="" \
style="margin-left: 3em; padding-left: 0;"><li \
class="">usr/src/cmd/devfsadm/devfsadm.c <span class="" style="color: \
grey">(6f2706c21a722e9d1eecdecf97498fe6fbc33bdf)</span><li \
class="">usr/src/cmd/devfsadm/devalloc.c <span class="" style="color: \
grey">(11147269cb22a5d9659511bccac62469e80b1c75)</span></ul><p class=""><a class="" \
href="https://www.illumos.org/rb/r/1039/diff/1/" style="margin-left: 3em;">View \
Diff</a></td></tr></tbody></table></div></div></div></blockquote></div><br class="" \
/></div><div id="topicbox-footer" style="margin:10px 0 0;border-top:1px solid \
#ddd;border-color:rgba(0,0,0,.15);padding:7px 0;">
<strong><a href="https://illumos.topicbox.com/latest" \
style="color:inherit;text-decoration:none">illumos</a></strong> /
<a href="https://illumos.topicbox.com/groups/developer/members">illumos-developer</a>
/
<a href="https://illumos.topicbox.com/groups/developer/discussions/Te4d4ba8fecfdf60b-M7527636ee794fd19121ed17a">Permalink</a>
<a href="https://illumos.topicbox.com/groups" style="float:right">Delivery \
options</a> </div>
</body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic