[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    Re: [developer] Review: 7627 Build should be smarter about how SGSPROTO is created
From:       "Robert Mustacchi" <rm () joyent ! com>
Date:       2016-11-29 23:25:38
Message-ID: 80c1d96d-942a-4c49-47eb-2c2a0ee3f059 () joyent ! com
[Download RAW message or body]

On 11/29/16 6:54 , Andy Stormont wrote:
> 
> On 29 Nov 2016, at 12:32, Andy Stormont \
> <AStormont@racktopsystems.com<mailto:AStormont@racktopsystems.com>> wrote: 
> 
> On 28 Nov 2016, at 21:47, Robert Mustacchi <rm@joyent.com<mailto:rm@joyent.com>> \
> wrote: 
> Looks good. Thanks.
> 
> I removed the $(PROG) target from usr/src/cmd/sgs/ld/Makefile.targ because it's \
> already defined in usr/src/cmd/Make.targ.  It's a clean-up really - but means that \
> the normal build target doesn't depend on $(SGSBINDIR) which is good if we decide \
> to add a mechanism to turn off building of the native stuff. 
> Does it still look good?
> 
> - Andy.
> 
> It turns out we do need the $(PROG) target (it's not defined in \
> usr/src/cmd/Makefile.cmd) so I put it back in, but separate from the native target. \
> I think this is cleaner.  The build completes without problems. 
> Webrev updated in place.

The updated version still looks good.

Robert



-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: \
https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a \
Powered by Listbox: http://www.listbox.com


[prev in list] [next in list] [prev in thread] [next in thread]