[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: [developer] [review request] 7605 we should not attempt to write to ZFS while panicing
From: "Matthew Ahrens" <mahrens () delphix ! com>
Date: 2016-11-29 21:20:47
Message-ID: CAJjvXiELU1uG2DPMrf5yL8qJKAosDuAvOy8ndBi-Osw+sXsMRQ () mail ! gmail ! com
[Download RAW message or body]
https://github.com/openzfs/openzfs/pull/245
When we panic, we should not attempt to write dirty pages to ZFS. This
is ineffective (since we don't wait for the txg to sync), and can cause
a subsequent panic if ZFS is not in a good state (or we are short on
stack space).
The fix is to never attempt to write dirty pages while panicking. This
allows us to clean up a bunch of now-unused code scattered through the VM
and VFS subsystems.
--matt
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a
Powered by Listbox: http://www.listbox.com
[Attachment #3 (text/html)]
<html><html><div dir="ltr"><a \
href="https://github.com/openzfs/openzfs/pull/245">https://github.com/openzfs/openzfs/pull/245</a><br \
/><div><br /></div><div><p \
style="box-sizing:border-box;margin-top:0px;margin-bottom:16px;color:rgb(51,51,51);font-family:-apple-system,blinkmacsystemfont,"segoe \
ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui \
emoji","segoe ui symbol";font-size:14px">When we panic, we should not \
attempt to write dirty pages to ZFS. This<br style="box-sizing:border-box" />is \
ineffective (since we don't wait for the txg to sync), and can cause<br \
style="box-sizing:border-box" />a subsequent panic if ZFS is not in a good state (or \
we are short on<br style="box-sizing:border-box" />stack space).</div><div>The fix is \
to never attempt to write dirty pages while panicking. This allows us to clean \
up a bunch of now-unused code scattered through the VM and VFS \
subsystems.</div><div><br /></div><div>--matt</div></div></html><div \
bgcolor="#ffffff" id="listbox-footer" \
style="width:auto;margin:0;padding:5px;background-color:#fff;clear:both;border-top: \
1px solid #ccc;"><table bgcolor="#ffffff" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#fff" width="100%"><tr><td padding="4px"><font \
color="#333333" size="1" style="font-family:helvetica, sans-serif;"> \
<strong>illumos-developer</strong> | <a \
href="https://www.listbox.com/member/archive/182179/=now" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" title="Go \
to archives for illumos-developer">Archives</a> <a border="0" \
href="https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc" \
style="text-decoration:none;color:#669933" title="RSS feed for \
illumos-developer"><img border="0" \
src="http://postlink.www.listbox.com/2257165/833487e62783d55fe81f119fb93ef644/25758058 \
/bb3fe179.jpg?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2ZlZWQtaWNvbi0xMHgxMC5qcGc" \
/></a> | <a href="https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" \
title="">Modify</a> Your Subscription<td align="right" valign="top"><a \
href="http://www.listbox.com" style="border-bottom:none;"> <img border="0" \
src="http://postlink.www.listbox.com/2257166/3379085af0f1cf7fc3708f04b4471ae2/25758058 \
/bb3fe179.png?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2xpc3Rib3gtbG9nby1zbWFsbC5wbmc" \
title="Powered by Listbox" /></a></td></font></td></tr></table></div></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic