[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    Re: [developer] Review: 7612 SGSPROTO lacks structure
From:       "Richard Lowe" <richlowe () richlowe ! net>
Date:       2016-11-24 16:44:33
Message-ID: CAA7J0x-wxMDjrv5P0sB_UKo9NjhwEYpQ_BGvhcNjOccQ6eH7MQ () mail ! gmail ! com
[Download RAW message or body]

This looks awesome.  Thanks for doing all this.

On Thu, Nov 24, 2016 at 6:31 AM Andy Stormont <astormont@racktopsystems.com>
wrote:

> Everything in SGSPROTO is thrown in together; executables and libraries
> are installed into the root of this directory.  It would make more sense if
> this directory was structured like a chroot.  This would allow installing a
> temporary linker into an alternate root by overriding SGSPROTO, like so:
> 
> $ cd usr/src/cmd/sgs && dmake SGSPROTO=$WORKSPACE/strap native-add
> 
> Issue: https://www.illumos.org/issues/7612
> Webrev: http://cr.illumos.org/~webrev/andy_js/7612
> 
> Before the fix SGSPROTO looks like this:
> 
> usr/src/cmd/sgs/proto/i386/
> usr/src/cmd/sgs/proto/i386/ld
> usr/src/cmd/sgs/proto/i386/liblddbg.so.4
> usr/src/cmd/sgs/proto/i386/libelf.so
> usr/src/cmd/sgs/proto/i386/libelf.so.1
> usr/src/cmd/sgs/proto/i386/libld.so.4
> usr/src/cmd/sgs/proto/i386/libldstab.so.1
> usr/src/cmd/sgs/proto/i386/liblddbg.so
> usr/src/cmd/sgs/proto/i386/libld.so
> 
> After the fix it looks like this:
> 
> usr/src/cmd/sgs/proto/i386/
> usr/src/cmd/sgs/proto/i386/usr
> usr/src/cmd/sgs/proto/i386/usr/bin
> usr/src/cmd/sgs/proto/i386/usr/bin/ld
> usr/src/cmd/sgs/proto/i386/lib
> usr/src/cmd/sgs/proto/i386/lib/liblddbg.so.4
> usr/src/cmd/sgs/proto/i386/lib/libelf.so
> usr/src/cmd/sgs/proto/i386/lib/libelf.so.1
> usr/src/cmd/sgs/proto/i386/lib/libld.so.4
> usr/src/cmd/sgs/proto/i386/lib/libldstab.so.1
> usr/src/cmd/sgs/proto/i386/lib/liblddbg.so
> usr/src/cmd/sgs/proto/i386/lib/libld.so
> 
> -  Andy.
> 
-- 

-- Rich



-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a
Powered by Listbox: http://www.listbox.com

[Attachment #3 (text/html)]

<html><html><div dir="ltr">This looks awesome.&nbsp; Thanks for doing all this.<br \
/><br /><div class="gmail_quote"><div dir="ltr">On Thu, Nov 24, 2016 at 6:31 AM Andy \
Stormont &lt;<a href="mailto:astormont@racktopsystems.com">astormont@racktopsystems.com</a>&gt; \
wrote:<br /></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Everything in SGSPROTO is thrown in \
together; executables and libraries are installed into the root of this \
directory.&nbsp; It would make more sense if this directory was structured like a \
chroot.&nbsp; This would allow installing a temporary linker into an alternate root \
by overriding SGSPROTO, like so:<br class="gmail_msg" /><br class="gmail_msg" /> $ cd \
usr/src/cmd/sgs &amp;&amp; dmake SGSPROTO=$WORKSPACE/strap native-add<br \
                class="gmail_msg" /><br class="gmail_msg" />
Issue: <a class="gmail_msg" href="https://www.illumos.org/issues/7612" \
rel="noreferrer" target="_blank">https://www.illumos.org/issues/7612</a><br \
                class="gmail_msg" />
Webrev: <a class="gmail_msg" href="http://cr.illumos.org/~webrev/andy_js/7612" \
rel="noreferrer" target="_blank">http://cr.illumos.org/~webrev/andy_js/7612</a><br \
class="gmail_msg" /><br class="gmail_msg" /> Before the fix SGSPROTO looks like \
this:<br class="gmail_msg" /><br class="gmail_msg" /> usr/src/cmd/sgs/proto/i386/<br \
class="gmail_msg" /> usr/src/cmd/sgs/proto/i386/ld<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/liblddbg.so.4<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/libelf.so<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/libelf.so.1<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/libld.so.4<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/libldstab.so.1<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/liblddbg.so<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/libld.so<br class="gmail_msg" /><br class="gmail_msg" />
After the fix it looks like this:<br class="gmail_msg" /><br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/usr<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/usr/bin<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/usr/bin/ld<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/liblddbg.so.4<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/libelf.so<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/libelf.so.1<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/libld.so.4<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/libldstab.so.1<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/liblddbg.so<br class="gmail_msg" />
usr/src/cmd/sgs/proto/i386/lib/libld.so<br class="gmail_msg" /><br class="gmail_msg" \
                />
- Andy.<br class="gmail_msg" /><br class="gmail_msg" /><a class="gmail_msg" \
href="http://www.listbox.com" rel="noreferrer" \
target="_blank">http://www.listbox.com</a><br class="gmail_msg" \
/></blockquote></div></div><div dir="ltr">-- <br /></div><div \
data-smartmail="gmail_signature"><p dir="ltr">-- Rich</div></html><div \
bgcolor="#ffffff" id="listbox-footer" \
style="width:auto;margin:0;padding:5px;background-color:#fff;clear:both;border-top: \
1px solid #ccc;"><table bgcolor="#ffffff" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#fff" width="100%"><tr><td padding="4px"><font \
color="#333333" size="1" style="font-family:helvetica, sans-serif;">  \
<strong>illumos-developer</strong> | <a \
href="https://www.listbox.com/member/archive/182179/=now" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" title="Go \
to archives for illumos-developer">Archives</a> <a border="0" \
href="https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc" \
style="text-decoration:none;color:#669933" title="RSS feed for \
illumos-developer"><img border="0" \
src="http://postlink.www.listbox.com/2254933/833487e62783d55fe81f119fb93ef644/25758058 \
/bb3fe179.jpg?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2ZlZWQtaWNvbi0xMHgxMC5qcGc" \
/></a>  | <a href="https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" \
title="">Modify</a>  Your Subscription<td align="right" valign="top"><a \
href="http://www.listbox.com" style="border-bottom:none;"> <img border="0" \
src="http://postlink.www.listbox.com/2254934/3379085af0f1cf7fc3708f04b4471ae2/25758058 \
/bb3fe179.png?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2xpc3Rib3gtbG9nby1zbWFsbC5wbmc" \
title="Powered by Listbox" /></a></td></font></td></tr></table></div></html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic