[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: Re: [developer] Review: 7595 sgs native-proto fails on pre-7029 illumos-gate
From: "Andy Stormont" <astormont () racktopsystems ! com>
Date: 2016-11-22 11:58:51
Message-ID: 421CC940-F0F6-4A64-9C0C-403C4C05354B () racktopsystems ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
In principal I agree. In practice I think it's going to be very difficult to provide \
more than just backwards compatibility so there's a migration path from older builds. \
I would say that this change (like the similar changes to the svc bits) need never be \
unifdef'd.
- Andy.
On 22 Nov 2016, at 00:57, Gordon Ross \
<gordon.w.ross@gmail.com<mailto:gordon.w.ross@gmail.com>> wrote:
Never? I know I'm a minority of "those who care about native stuff ever building on \
some other OS", but ideally all the "native" stuff should assume nothing about the \
build system beyond "some sort of POSIX OS".
On Mon, Nov 21, 2016 at 6:17 PM, Richard Lowe \
<richlowe@richlowe.net<mailto:richlowe@richlowe.net>> wrote: Looks good.
Do we want to add some indication of when it can be unifdef'd?
-- Rich
On Sun, Nov 20, 2016 at 7:29 AM Andy Stormont \
<astormont@racktopsystems.com<mailto:astormont@racktopsystems.com>> wrote: As of 7029 \
the native sgs components depend on the host having sys/secflags.h. This makes \
migration painful because in order to build post-7029 illumos-gate you must already \
be running post-7029 illumos-gate.
To get around this recursive dependency the native sgs components should be made not \
to require on sys/secflags.h. Something similar was already implemented for the \
native svc components which are used only during the build process (to generate the \
seed repo).
If you are not using the native-proto mechanism to produce a temporary linker as part \
of your build process - which I would assume is pretty much everybody on this list - \
you won't run into this problem.
Issue: https://illumos.org/issues/7595
Webrev: http://cr.illumos.org/~webrev/andy_js/7595/
- Andy.
--
-- Rich
illumos-developer | Archives<https://www.listbox.com/member/archive/182179/=now> \
[https://www.listbox.com/images/feed-icon-10x10.jpg957ae61.jpg?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2ZlZWQtaWNvbi0xMHgxMC5qcGc] \
<https://www.listbox.com/member/archive/rss/182179/21174975-4ab5ff23> | \
Modify<https://www.listbox.com/member/?&> Your Subscription \
[https://www.listbox.com/images/listbox-logo-small.png957ae61.png?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2xpc3Rib3gtbG9nby1zbWFsbC5wbmc] \
<http://www.listbox.com/>
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: \
https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a \
Powered by Listbox: http://www.listbox.com
[Attachment #3 (text/html)]
<html><html><html><head><meta content="text/html; charset=utf-8" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class="">In \
principal I agree. In practice I think it’s going to be very difficult to \
provide more than just backwards compatibility so there’s a migration path from \
older builds. I would say that this change (like the similar changes to the svc \
bits) need never be unifdef’d.</div><div class=""><br class="" /></div><div \
class="">- Andy.</div><br class="" /><div><blockquote class="" type="cite"><div \
class="">On 22 Nov 2016, at 00:57, Gordon Ross <<a class="" \
href="mailto:gordon.w.ross@gmail.com">gordon.w.ross@gmail.com</a>> wrote:</div><br \
class="Apple-interchange-newline" /><div class=""><div class="" \
dir="ltr">Never? I know I'm a minority of "those who care about native \
stuff ever building on some other OS", but ideally all the "native" \
stuff should assume nothing about the build system beyond "some sort of POSIX \
OS". <div class=""><br class="" /></div></div><div class="gmail_extra"><br \
class="" /><div class="gmail_quote">On Mon, Nov 21, 2016 at 6:17 PM, Richard Lowe \
<span class="" dir="ltr"> <<a class="" href="mailto:richlowe@richlowe.net" \
target="_blank">richlowe@richlowe.net</a>></span> wrote:<br class="" /><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="" dir="ltr">Looks good. <div class=""><br \
class="" /></div><div class="">Do we want to add some indication of when it can be \
unifdef'd?</div><div class=""><br class="" /></div><div class="">-- \
Rich</div></div><span class=""><br class="" /><div class="gmail_quote"><div class="" \
dir="ltr">On Sun, Nov 20, 2016 at 7:29 AM Andy Stormont <<a class="" \
href="mailto:astormont@racktopsystems.com" \
target="_blank">astormont@racktopsystems.com</a>> wrote:<br class="" \
/></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="m_8100499204997601075gmail_msg" \
style="word-wrap:break-word"><div class="m_8100499204997601075gmail_msg">As of 7029 \
the native sgs components depend on the host having sys/secflags.h. This makes \
migration painful because in order to build post-7029 illumos-gate you must \
already be running post-7029 illumos-gate.</div><div \
class="m_8100499204997601075gmail_msg"><br class="m_8100499204997601075gmail_msg" \
/></div><div class="m_8100499204997601075gmail_msg">To get around this recursive \
dependency the native sgs components should be made not to require on \
sys/secflags.h. Something similar was already implemented for the native svc \
components which are used only during the build process (to generate the seed \
repo).<br class="m_8100499204997601075gmail_msg" /></div><div \
class="m_8100499204997601075gmail_msg"><br class="m_8100499204997601075gmail_msg" \
/></div><div class="m_8100499204997601075gmail_msg">If you are not using the \
native-proto mechanism to produce a temporary linker as part of your build process - \
which I would assume is pretty much everybody on this list - you won’t run into \
this problem.</div><div class="m_8100499204997601075gmail_msg"><br \
class="m_8100499204997601075gmail_msg" /></div> Issue: <a \
class="m_8100499204997601075gmail_msg" href="https://illumos.org/issues/7595" \
target="_blank">https://illumos.org/<wbr class="" />issues/7595</a><div \
class="m_8100499204997601075gmail_msg">Webrev: <a \
class="m_8100499204997601075gmail_msg" \
href="http://cr.illumos.org/~webrev/andy_js/7595/" \
target="_blank">http://cr.illumos.org/<wbr class="" \
/>~webrev/andy_js/7595/</a></div><div class="m_8100499204997601075gmail_msg"><br \
class="m_8100499204997601075gmail_msg" /></div><div \
class="m_8100499204997601075gmail_msg">- \
Andy.</div></div></blockquote></div></span><span class="HOEnZb"><font class="" \
color="#888888"><div class="" dir="ltr">-- <br class="" /></div><div class="" \
data-smartmail="gmail_signature"><p class="" dir="ltr">-- \
Rich</div></font></span></blockquote></div><br class="" \
/></div></div></blockquote></div><br class="" /><div bgcolor="#ffffff" \
id="listbox-footer" style="width:auto;margin:0;padding:5px;background-color:#fff;clear:both;border-top: \
1px solid #ccc;"><table bgcolor="#ffffff" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#fff" width="100%"><tr><td padding="4px"><font \
color="#333333" size="1" style="font-family:helvetica, sans-serif;"> \
<strong>illumos-developer</strong> | <a \
href="https://www.listbox.com/member/archive/182179/=now" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" title="Go \
to archives for illumos-developer">Archives</a> <a border="0" \
href="https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc" \
style="text-decoration:none;color:#669933" title="RSS feed for \
illumos-developer"><img border="0" \
src="http://postlink.www.listbox.com/2253463/833487e62783d55fe81f119fb93ef644/25758058 \
/bb3fe179.jpg?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2ZlZWQtaWNvbi0xMHgxMC5qcGc" \
/></a> | <a href="https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" \
title="">Modify</a> Your Subscription<td align="right" valign="top"><a \
href="http://www.listbox.com" style="border-bottom:none;"> <img border="0" \
src="http://postlink.www.listbox.com/2253464/3379085af0f1cf7fc3708f04b4471ae2/25758058 \
/bb3fe179.png?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2xpc3Rib3gtbG9nby1zbWFsbC5wbmc" \
title="Powered by Listbox" \
/></a></td></font></td></tr></table></div></body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic