[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: Re: [developer] Review: 7592 acpi commands link against host libc
From: "Toomas Soome" <tsoome () me ! com>
Date: 2016-11-18 20:44:06
Message-ID: 59CEC346-868F-4C74-B034-313276A29547 () me ! com
[Download RAW message or body]
+1.
Perhaps we should have nice generic build rule for cmd/Makefile.cmd - currently it \
only has rules for single source targets, but thats just as side note and not about \
this change.
> On 18. nov 2016, at 22:37, Andy Stormont <astormont@racktopsystems.com> wrote:
>
> The acpi commands are linking against libc outside of the proto area because LDLIBS \
> (which includes all of the -L flags) is not being passed when linking.
> Issue: https://illumos.org/issues/7592 <https://illumos.org/issues/7592>
> Webrev: http://cr.illumos.org/~webrev/andy_js/7592/ \
> <http://cr.illumos.org/~webrev/andy_js/7592/>
> - Andy.
> illumos-developer | Archives <https://www.listbox.com/member/archive/182179/=now> \
> <https://www.listbox.com/member/archive/rss/182179/25767304-1660182a> | Modify \
> <https://www.listbox.com/member/?&> Your Subscription <http://www.listbox.com/>
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: \
https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a \
Powered by Listbox: http://www.listbox.com
[Attachment #3 (unknown)]
<html><html><html><head><meta content="text/html charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div \
class="">+1.</div><div class=""><br class="" /></div><div class=""><br class="" \
/></div><div class="">Perhaps we should have nice generic build rule for \
cmd/Makefile.cmd - currently it only has rules for single source targets, but \
thats just as side note and not about this change.</div><div class=""><br class="" \
/></div><br class="" /><div><blockquote class="" type="cite"><div class="">On 18. nov \
2016, at 22:37, Andy Stormont <<a class="" \
href="mailto:astormont@racktopsystems.com">astormont@racktopsystems.com</a>> \
wrote:</div><br class="Apple-interchange-newline" /><div class=""><meta class="" \
content="text/html; charset=us-ascii" http-equiv="Content-Type" /><div class="" \
style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;"> The acpi commands are linking against libc outside of the proto \
area because LDLIBS (which includes all of the -L flags) is not being passed when \
linking. <div class=""><br class="" /></div><div class="">Issue: <a \
class="" href="https://illumos.org/issues/7592">https://illumos.org/issues/7592</a></div><div \
class="">Webrev: <a class="" \
href="http://cr.illumos.org/~webrev/andy_js/7592/">http://cr.illumos.org/~webrev/andy_js/7592/</a></div><div \
class=""><br class="" /></div><div class="">- \
Andy.</div></div></div></blockquote></div><br class="" /><div bgcolor="#ffffff" \
id="listbox-footer" style="width:auto;margin:0;padding:5px;background-color:#fff;clear:both;border-top: \
1px solid #ccc;"><table bgcolor="#ffffff" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#fff" width="100%"><tr><td padding="4px"><font \
color="#333333" size="1" style="font-family:helvetica, sans-serif;"> \
<strong>illumos-developer</strong> | <a \
href="https://www.listbox.com/member/archive/182179/=now" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" title="Go \
to archives for illumos-developer">Archives</a> <a border="0" \
href="https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc" \
style="text-decoration:none;color:#669933" title="RSS feed for \
illumos-developer"><img border="0" \
src="http://postlink.www.listbox.com/2251377/833487e62783d55fe81f119fb93ef644/25758058 \
/bb3fe179.jpg?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2ZlZWQtaWNvbi0xMHgxMC5qcGc" \
/></a> | <a href="https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" \
title="">Modify</a> Your Subscription<td align="right" valign="top"><a \
href="http://www.listbox.com" style="border-bottom:none;"> <img border="0" \
src="http://postlink.www.listbox.com/2251378/3379085af0f1cf7fc3708f04b4471ae2/25758058 \
/bb3fe179.png?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2xpc3Rib3gtbG9nby1zbWFsbC5wbmc" \
title="Powered by Listbox" \
/></a></td></font></td></tr></table></div></body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic