[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    Re: [developer] [REVIEW] (again) 5713, 5714, 5715 updates to share man pages
From:       "Robert Mustacchi" <rm () joyent ! com>
Date:       2016-06-29 23:28:49
Message-ID: 1293b549-293d-7c55-b285-0b518035d902 () joyent ! com
[Download RAW message or body]

On 6/28/16 7:58 , Yuri Pankov wrote:
> On Tue, 21 Jun 2016 16:50:41 -0700, Robert Mustacchi wrote:
>> On 6/19/16 7:38 , Yuri Pankov wrote:
>>> issue: https://www.illumos.org/issues/5713
>>> issue: https://www.illumos.org/issues/5714
>>> issue: https://www.illumos.org/issues/5715
>>> webrev: http://www.xvoid.org/illumos/webrev/il-man-share/
>>>
>>> The changes are tied together thus one webrev.
>>>
>>> - remove NFS/SMB options and access_list description from sharemgr(1M)
>>> - remove access_list description from share_nfs(1M)
>>> - add share_smb(1M) describing SMB options
>>> - add shareacl(4) describing access_list format
>>
>> I started going through this and I'm a bit confused. Your sharemgr(1M)
>> in sdiffs doesn't look anything like the one currently in the gate. What
>> was this built against? I have more specific comments below:
> 
> Sorry, forgot the conversion diff, which also moved the examples to
> where they belong - I understand that this makes the review harder, and
> I'm sorry for that, but I did that work long ago and just don't want to
> see it got lost.
> 
> http://www.xvoid.org/illumos/webrev/il-man-sharemgr-mdoc/

For what it's worth, it wasn't just the example shuffling, but also the
reordering and the options changing a bunch. I've tried to go through
this as best as I can.

I don't quite get why -h is going away, especially when this is noted as
committed.

Would it be possible to make sure that we have references to the
examples. e.g. see example n.

sharemgr unset used to take a [-s sharepath] option in the long form. It
doesn't seem to in the synopsis or otherwise anymore in the new form;
however, you still reference the -s option in the description. What
should it be?

Robert


-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a
Powered by Listbox: http://www.listbox.com
[prev in list] [next in list] [prev in thread] [next in thread]