[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: Re: [zfs] Re: [developer] [REVIEW] zpool(1M) man page fixes
From: "Matthew Ahrens" <mahrens () delphix ! com>
Date: 2016-02-25 18:02:26
Message-ID: CAJjvXiGQom+Q7DG2T0M2dTb0LfVXLWKzeshL50byhvCUzhQ93w () mail ! gmail ! com
[Download RAW message or body]
LGTM.
--matt
On Wed, Feb 24, 2016 at 11:48 PM, Yuri Pankov <yuri.pankov@nexenta.com>
wrote:
> On Wed, 24 Feb 2016 16:30:21 -0800, Matthew Ahrens wrote:
>
>>
>>
>> On Fri, Feb 19, 2016 at 7:31 PM, Yuri Pankov <yuri.pankov@nexenta.com
>> <mailto:yuri.pankov@nexenta.com>> wrote:
>>
>> webrevs are incremental in the following order:
>>
>> webrev: http://www.xvoid.org/illumos/webrev/il-man-zpool-mdoc/
>> Convert zpool(1M) to mdoc, not touching the contents (mostly, fixed
>> several typos).
>>
>>
>> Didn't look at this but this seems like a good idea, thanks.
>>
>> issue: https://illumos.org/issues/2897
>> webrev: http://www.xvoid.org/illumos/webrev/il-man-zpool-split/
>> Add the zpool split documentation, taken from
>>
>> https://github.com/zfsonlinux/zfs/commit/fb827006163574fddb7fa837109d228dacd2ebf6
>> .
>>
>>
>> This can be useful to avoid mountpoint collisions if
>> 1373 .Ar newpool
>> 1374 is imported on the same filesystem as
>> 1375 .Ar pool .
>>
>> What do you mean by "filesystem"? Seems like the mountpoint collision
>> would happen any time the mount property is explicitly set (as opposed
>> to inheriting from the pool name).
>>
>
> That came from original ZoL change I used, I have removed the entire
> sentence.
>
> issue: https://illumos.org/issues/5659
>> webrev: http://www.xvoid.org/illumos/webrev/il-man-zpool-5659/
>> Fix several uses of word 'zpool' to describe storage pool (not
>> command).
>>
>>
>> 463 Do not add a disk that is currently configured as a
>> quorum device
>> 464 to the pool. After a disk is in the pool, that disk can then be
>> 465 configured as a quorum device.
>>
>> I realize that this has existed for all time, but do you know what it's
>> talking about? AFAIK there is no concept of "quorum device" in ZFS, and
>> this paragraph should be removed.
>>
>
> The quorum paragraph removed.
>
> issue: https://illumos.org/issues/4465
>> webrev: http://www.xvoid.org/illumos/webrev/il-man-zpool-4465/
>> Don't say that zpool offline/online doesn't work for cache devices
>> (as it does for a long time).
>>
>>
>> Looks good.
>>
>
> webrevs updated in-place.
>
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a
Powered by Listbox: http://www.listbox.com
[Attachment #3 (text/html)]
<html><html><div dir="ltr">LGTM.<div><br /></div><div>--matt</div></div><div \
class="gmail_extra"><br /><div class="gmail_quote">On Wed, Feb 24, 2016 at 11:48 PM, \
Yuri Pankov <span dir="ltr"><<a href="mailto:yuri.pankov@nexenta.com" \
target="_blank">yuri.pankov@nexenta.com</a>></span> wrote:<br /><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On Wed, 24 Feb 2016 16:30:21 -0800, Matthew \
Ahrens wrote:<br /></span><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br /><br /> On Fri, \
Feb 19, 2016 at 7:31 PM, Yuri Pankov <<a href="mailto:yuri.pankov@nexenta.com" \
target="_blank">yuri.pankov@nexenta.com</a><br /></span><span class=""> <mailto:<a \
href="mailto:yuri.pankov@nexenta.com" \
target="_blank">yuri.pankov@nexenta.com</a>>> wrote:<br /><br /> \
webrevs are incremental in the following order:<br /><br /> webrev: <a \
href="http://www.xvoid.org/illumos/webrev/il-man-zpool-mdoc/" rel="noreferrer" \
target="_blank">http://www.xvoid.org/illumos/webrev/il-man-zpool-mdoc/</a><br /> \
Convert zpool(1M) to mdoc, not touching the contents (mostly, fixed<br \
/> several typos).<br /><br /><br />
Didn't look at this but this seems like a good idea, thanks.<br /><br />
issue: <a href="https://illumos.org/issues/2897" rel="noreferrer" \
target="_blank">https://illumos.org/issues/2897</a><br /> webrev: <a \
href="http://www.xvoid.org/illumos/webrev/il-man-zpool-split/" rel="noreferrer" \
target="_blank">http://www.xvoid.org/illumos/webrev/il-man-zpool-split/</a><br /> \
Add the zpool split documentation, taken from<br /> <a \
href="https://github.com/zfsonlinux/zfs/commit/fb827006163574fddb7fa837109d228dacd2ebf6" \
rel="noreferrer" target="_blank">https://github.com/zfsonlinux/zfs/commit/fb827006163574fddb7fa837109d228dacd2ebf6</a>.<br \
/><br /><br /> This can be useful to avoid mountpoint collisions if<br />
1373 .Ar newpool<br />
1374 is imported on the same filesystem as<br />
1375 .Ar pool .<br /><br />
What do you mean by "filesystem"? Seems like the mountpoint \
collision<br /> would happen any time the mount property is explicitly set (as \
opposed<br /> to inheriting from the pool name).<br /></span></blockquote><br />
That came from original ZoL change I used, I have removed the entire sentence.<span \
class=""><br /><br /><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> issue: <a \
href="https://illumos.org/issues/5659" rel="noreferrer" \
target="_blank">https://illumos.org/issues/5659</a><br /> webrev: <a \
href="http://www.xvoid.org/illumos/webrev/il-man-zpool-5659/" rel="noreferrer" \
target="_blank">http://www.xvoid.org/illumos/webrev/il-man-zpool-5659/</a><br /> \
Fix several uses of word 'zpool' to describe storage pool (not \
command).<br /><br /><br /> 463 \
Do not add a disk that is currently configured as a quorum device<br /> 464 to \
the pool. After a disk is in the pool, that disk can then be<br /> 465 \
configured as a quorum device.<br /><br /> \
I realize that this has existed for all time, but do you know what it's<br /> \
talking about? AFAIK there is no concept of "quorum device" in ZFS, \
and<br /> this paragraph should be removed.<br /></blockquote><br /></span>
The quorum paragraph removed.<span class=""><br /><br /><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> issue: <a \
href="https://illumos.org/issues/4465" rel="noreferrer" \
target="_blank">https://illumos.org/issues/4465</a><br /> webrev: <a \
href="http://www.xvoid.org/illumos/webrev/il-man-zpool-4465/" rel="noreferrer" \
target="_blank">http://www.xvoid.org/illumos/webrev/il-man-zpool-4465/</a><br /> \
Don't say that zpool offline/online doesn't work for cache \
devices<br /> (as it does for a long time).<br /><br /><br />
Looks good.<br /></blockquote><br /></span>
webrevs updated in-place.<div class="HOEnZb"><div class="h5"><br /><br /><br /><a \
href="http://www.listbox.com" rel="noreferrer" \
target="_blank">http://www.listbox.com</a><br /></div></div></blockquote></div><br \
/></div></html><div bgcolor="#ffffff" id="listbox-footer" \
style="width:auto;margin:0;padding:5px;background-color:#fff;clear:both;border-top: \
1px solid #ccc;"><table bgcolor="#ffffff" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#fff" width="100%"><tr><td padding="4px"><font \
color="#333333" size="1" style="font-family:helvetica, sans-serif;"> \
<strong>illumos-developer</strong> | <a \
href="https://www.listbox.com/member/archive/182179/=now" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" title="Go \
to archives for illumos-developer">Archives</a> <a border="0" \
href="https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc" \
style="text-decoration:none;color:#669933" title="RSS feed for \
illumos-developer"><img border="0" \
src="http://postlink.www.listbox.com/2067954/833487e62783d55fe81f119fb93ef644/25758058 \
/bb3fe179.jpg?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2ZlZWQtaWNvbi0xMHgxMC5qcGc" \
/></a> | <a href="https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a" \
style="text-decoration:none;color:#669933;border-bottom: 1px solid #444444" \
title="">Modify</a> Your Subscription<td align="right" valign="top"><a \
href="http://www.listbox.com" style="border-bottom:none;"> <img border="0" \
src="http://postlink.www.listbox.com/2067955/3379085af0f1cf7fc3708f04b4471ae2/25758058 \
/bb3fe179.png?uri=aHR0cHM6Ly93d3cubGlzdGJveC5jb20vaW1hZ2VzL2xpc3Rib3gtbG9nby1zbWFsbC5wbmc" \
title="Powered by Listbox" /></a></td></font></td></tr></table></div></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic