[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    Re: [developer] Webrev for: 6596 Macro redefined in strtolctype.h
From:       "Gary Mills" <gary_mills () fastmail ! fm>
Date:       2016-02-22 16:09:45
Message-ID: 20160222160945.GA28100 () mail ! messagingengine ! com
[Download RAW message or body]

On Wed, Feb 17, 2016 at 03:58:37PM -0800, Garrett D'Amore wrote:
>    Actually, what I really want is the comment to also say something to
>    the effect of �please don�t use these macros or this header outside of
>    dtrace or boot loaders�.�  Specifically, I�d like to avoid seeing this
>    crop up all over the kernel. �  (It might be too late for that, I�m not
>    sure.) �

Okay, I've changed the comments in strtolctype.h again.  I hope they
are satisfactory now.  I agree that use of this header should be
minimized in illumos.  My updated webrev is at:

    http://cr.illumos.org/~webrev/jgmills/6596-1

>    Interestingly enough, I notice that the header #ifdef guard is
>    wrong, too.�  Can you fix that? � (I�m surprised hdrchk didn�t gripe at
>    you.)

I've fixed that as well.  My builds on SPARC and x86 were successful.

Another review would be useful too.

-- 
-Gary Mills-		-refurb-		-Winnipeg, Manitoba, Canada-


-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/25758058-4e9228dc
Modify Your Subscription: https://www.listbox.com/member/?member_id=25758058&id_secret=25758058-c19b436a
Powered by Listbox: http://www.listbox.com
[prev in list] [next in list] [prev in thread] [next in thread]