[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ibm-acpi-devel
Subject:    [ibm-acpi-devel] [PATCH 00/11] driver: thikpad_acpi: deal with checkpatch issues
From:       Konrad Zapalowicz <bergo.torino () gmail ! com>
Date:       2014-04-21 19:10:45
Message-ID: 1398107456-31080-1-git-send-email-bergo.torino () gmail ! com
[Download RAW message or body]

This serie of patches deals with the checkpatch errors and warnings
found in the ./drivers/platform/x86/thinkpad_acpi.c file. In total
approx. 76 items have been fixed and in particular these are:
	- spaces required around that '?' (ctx:VxW)
	- "foo* const bar" should be "foo * const bar"
	- Prefer seq_puts to seq_printf
	- Missing a blank line after declarations
	- braces {} are not necessary for any arm of this statement
	- inline keyword should sit between storage class and type
	- static const char * array should probably be
	  static const char * const
	- simple_strtoul is obsolete, use kstrtoul instead
	- __packed is preferred over __attribute__((packed))
	- Missing a blank line after declarations
	- Unnecessary space before function pointer arguments
	- Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
	- Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
	  dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...

The most significiant change is the "simple_strtoul is obsolete, use
kstrtoul instead" therefore this patch should be reviewed carefully.

The linux-next tree (36efbdf) has been used as a base for this work.

Konrad Zapalowicz (11):
  driver: thinkpad_acpi: add spaces around ?
  driver: thinkpad_acpi: add parenthesis around complex macro
  driver: thinkpad_acpi: fix minor checkpatch errors
  driver: thinkpad_acpi: replace seq_printf with seq_puts
  driver: thinkpad_acpi: add blank line after declaration
  driver: thinkpad_acpi: remove unnecessary spaces
  driver: thinkpad_acpi: remove not necessary {} braces
  driver: thinkpad_acpi: replace printk with pr_debug
  driver: thinkpad_acpi: replace simple_strtoul with kstrtoul
  driver: thinkpad_acpi: fix minor checkpatch warnings
  driver: thinkpad_acpi: remove spaces at the beginning

 drivers/platform/x86/thinkpad_acpi.c | 230 ++++++++++++++++++-----------------
 1 file changed, 119 insertions(+), 111 deletions(-)

-- 
1.8.1.2


------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
[prev in list] [next in list] [prev in thread] [next in thread]