[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: [RFC PATCH 0/7] Forward merging entries and other VM shenanigans
From:       Samuel Thibault <samuel.thibault () gnu ! org>
Date:       2023-08-30 9:09:18
Message-ID: 20230830090918.uib5vinuzx4ttdou () begin
[Download RAW message or body]

Sergey Bugaev, le mer. 30 août 2023 12:02:20 +0300, a ecrit:
> Hello,
> 
> On Wed, Aug 30, 2023 at 2:16 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > Just to make sure, may your work be affected by this?
> >
> > https://lists.gnu.org/archive/html/bug-hurd/2017-10/msg00011.html
> 
> Yes, I learned about that patch just after having sent mine.
> 
> > We had a patch in Debian that was disabling the coalescing because it
> > could potentially coalesce areas not to be swappable (such as IDE write
> > buffers) with swappable areas.
> 
> Not that I have any idea how IDE drivers work, but that patch sounds
> rather pointless, since that very 'if' condition already checks for
> the vm_entry being wired (= not swappable), and doesn't coalesce in
> that case. Also, according to [0], that patch fixed nothing at the
> time. So it should be safe to just drop it, which I see you have
> already done.

Ok, good :)

Thanks,
Samuel

[prev in list] [next in list] [prev in thread] [next in thread]