[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: [PATCH] hurd: unwinding support over signal trampolines
From:       Simon Marchi <simark () simark ! ca>
Date:       2020-05-30 15:07:20
Message-ID: ab01825a-f3f2-e3c5-1b14-7a1022b980e0 () simark ! ca
[Download RAW message or body]

On 2020-05-29 7:00 p.m., Samuel Thibault wrote:
> gdb/ChangeLog:
> 
> 2020-05-29  Samuel Thibault  <samuel.thibault@ens-lyon.org>
> 
> 	* i386-gnu-tdep.c: Include "gdbcore.h"
> 	(gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
>         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
>         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
>         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
>         i386_gnu_sigcontext_addr): New functions
>         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
>         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
>         tdep.

Please add a commit message.  It should at least explain why this change is needed / desirable
(what case isn't working, what functionality is missing) and what it does to address that (not
in terms of which functions are added / removed, but how the GDB behavior changes as a
consequence of that change).  If the "how" is complex, it's always good to include some notes
about that to help those who aren't experts of the system you work on.

Simon

[prev in list] [next in list] [prev in thread] [next in thread]