[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3)
From:       Samuel Thibault <samuel.thibault () gnu ! org>
Date:       2016-08-30 21:21:40
Message-ID: 20160830212140.GJ4435 () var ! home
[Download RAW message or body]

Svante Signell, on Tue 30 Aug 2016 17:40:00 +0200, wrote:
> Attached is an updated patch returning also EINVAL if abs(delta) is too large.

Never mix changes, please.

> Whether the  adjtime()/RPC_host_adjust_time.c:___host_adjust_time() survives a
> delta being NULL remains to test.

Well, there is no need to test::)

*(time_value_t *) delta,

will just crash.

> According to the manpage the bug was:

Again, note that manpages are often talking about the Linux
implementation only :)

We should probably try to implement the delta==NULL feature, though.

Thanks for the patch,
Samuel

[prev in list] [next in list] [prev in thread] [next in thread]