[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3)
From:       Pino Toscano <toscano.pino () tiscali ! it>
Date:       2016-08-30 12:45:39
Message-ID: 1909634.hQIzNno7c3 () thyrus ! usersys ! redhat ! com
[Download RAW message or body]

On Tuesday, 30 August 2016 14:32:32 CEST Svante Signell wrote:
> The glibc patch sysdeps_mach_hurd_adjtime.c.diff use a dummy struct timeval to
> avoid calling ___host_adjust_time() in _adjtime() with a NULL third argument.
> Smarter solutions can probably be found, comments are welcome.

You don't need to duplicate the whole __host_adjust_time call:

  struct timeval dummy;
  ..
  if (olddelta == NULL)
    olddelta = &dummy;

should be enough.

-- 
Pino Toscano

[prev in list] [next in list] [prev in thread] [next in thread]