[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    [bug #48437] diskfs_S_file_set_translator shortcutting "/hurd/fifo" to S_IFIFO discards options
From:       Kalle Olavi Niemitalo <INVALID.NOREPLY () gnu ! org>
Date:       2016-07-07 12:31:31
Message-ID: 20160707-123128.sv38928.29771 () savannah ! gnu ! org
[Download RAW message or body]

URL:
  <http://savannah.gnu.org/bugs/?48437>

                 Summary: diskfs_S_file_set_translator shortcutting
"/hurd/fifo" to S_IFIFO discards options
                 Project: The GNU Hurd
            Submitted by: kon
            Submitted on: Thu Jul  7 12:31:28 2016
                Category: Hurd Servers
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Reproducibility: Every Time
              Size (loc): None
         Planned Release: None
                  Effort: 0.00
Wiki-like text discussion box: 

    _______________________________________________________

Details:

Using hurd 1:0.8.git20160522-4 from Debian:


$ ls -ld hop
ls: cannot access 'hop': No such file or directory
$ touch hop
$ settrans hop /hurd/fifo --multiple-readers
$ showtrans hop
/hurd/fifo


The output from showtrans should have been "/hurd/fifo --multiple-readers".
This happens on ext2fs and tmpfs.

ext2fs uses libdiskfs/file-set-trans.c, which recognizes "/hurd/fifo" and
converts it to S_IFIFO, but ignores the arguments.  In contrast, if it
converts "/hurd/symlink" to S_IFLNK, it saves the first argument of the
translator as the target of the symlink (and ignores any remaining arguments).
 I think it should check that it understood everything that was in the
arguments, and if not, save the arguments unchanged as if it hadn't recognized
the translator.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48437>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


[prev in list] [next in list] [prev in thread] [next in thread]