[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: A small patch for the Hurd Reference Manual
From:       Samuel Thibault <samuel.thibault () gnu ! org>
Date:       2015-09-28 23:20:57
Message-ID: 20150928232057.GN2753 () var ! home
[Download RAW message or body]

Hello,

Thanks for your fixes.

Joshua Branson, le Fri 25 Sep 2015 13:52:25 -0400, a =E9crit :
>     This might be a significant enough change to require me assigning
> copyright to the FSF.

I don't think so for these changes: most of the wording was already in
the documentation, so in the end you brought plumbing, which is not
copyrightable.  That doesn't mean your contribution was welcome, of
course :)

>     I might continue to make some tiny changes to the hurd documentatio=
n in
> the future, time permitting.

If they remain tiny, then no copyright assignment is needed, but I guess
you'll try to document more, in which case we'll need an assignment.

>     Would someone assist me in assigning copyright to the FSF? Should I=
 send
> one of the files found here?
>     http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright

Please use this one, yes:

http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-as=
sign.future

> diff --git a/.gitignore b/.gitignore
> deleted file mode 100644
> index 1719508..0000000
> --- a/.gitignore
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -*~
> -
> -*.d
> -*.o
> -*.a
> -*.so
> -*.so.*
> -TAGS
> -
> -autom4te.cache/
> -/config.log
> -/config.make
> -/config.status
> -/configure
> -/version.h

You were removing .gitignore here...

Joshua Branson, le Mon 28 Sep 2015 08:53:03 -0400, a =E9crit :
> I've modified my patch.diff to fix the problems you had with the first
> draft.

Well, actually you created a patch which was to be applied on top of the
previous one.  Please don't do that, create a patch which still applies
to the hurd master.

> 1) Added my .gitignore back to the diff. BUT that means that I've added=
 some
> lines to the .gitignore, because I ran texi2pdf inside the hurd/doc
> directory.  If it is not advisable to add more lines to the .gitignore,=
 then
> I can fix that as well.

No, it's fine to add more lines to .gitignore.  Do not however add lines
like:

> +/patch.diff
> +/doc/patch.diff

since thoses are just your files, not normally generated by Makefile.

Thanks,
Samuel

[prev in list] [next in list] [prev in thread] [next in thread]