[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: Conflicting =?UTF-8?B?4oCYdGhyZWFkX2luZm9fdOKAmQ==?= declaration between nscd and Mach
From:       Pino Toscano <toscano.pino () tiscali ! it>
Date:       2014-06-21 22:37:16
Message-ID: 701719717.TGXmmJ2NNx () dhcp130-204 ! brq ! redhat ! com
[Download RAW message or body]

On Saturday 21 June 2014 23:29:43 Ludovic Courtès wrote:
> Roland McGrath <roland@hack.frob.com> skribis:
> > Send a patch upstream to libc to avoid using the *_t name space for
> > non-public type names like the one in nscd.  We'll take it.
> 
> Great, will do.
> 
> Manolis: could you confirm that the attached patch allows you to build
> libc for the Hurd with nscd support?
> 
> diff --git a/nscd/nscd.c b/nscd/nscd.c
> index 5680378..c910fd5 100644
> --- a/nscd/nscd.c
> +++ b/nscd/nscd.c
> @@ -61,14 +61,14 @@
>     and under a shutdown condition to wait till all in-progress
>     requests have finished before "turning off the lights".  */
>  
> -typedef struct
> +struct thread_info
>  {
>    int             num_active;
>    pthread_cond_t  thread_exit_cv;
>    pthread_mutex_t mutex;
> -} thread_info_t;
> +};
>  
> -thread_info_t thread_info;
> +struct thread_info thread_info;

Or what about simply getting rid of thread_info_t struct and thread_info 
variable, since they don't seem to be used at all within nscd?
(Of course, that would require testing also on Linux.)

-- 
Pino Toscano

[prev in list] [next in list] [prev in thread] [next in thread]