[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: [PATCH] implement SO_ACCEPTCONN in pflocal
From:       Samuel Thibault <samuel.thibault () gnu ! org>
Date:       2013-09-07 20:45:12
Message-ID: 20130907204512.GE5476 () type
[Download RAW message or body]

Pino Toscano, le Sat 07 Sep 2013 18:47:23 +0200, a écrit :
> +	case SO_ACCEPTCONN:
> +	  assert (*value_len >= sizeof (int));
> +	  *(int *)*value = user->sock->addr != NULL ? 1 : 0;

Shouldn't that rather be looking at what S_socket_listen does?  AIUI,
SO_ACCEPTCONN returns whether listen() has been called or not.

> +	  *value_len = sizeof (int);
> +	  break;
>  	default:
>  	  ret = ENOPROTOOPT;
>  	  break;
> -- 
> 1.8.4.rc3
> 

[prev in list] [next in list] [prev in thread] [next in thread]