[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd.
From:       Ivan Shmakov <oneingray () gmail ! com>
Date:       2013-07-09 10:59:01
Message-ID: 87sizovw22.fsf () violet ! siamics ! net
[Download RAW message or body]

>>>>> Justus Winter <4winter@informatik.uni-hamburg.de> writes:

 > This is essentially the same as
 > 89f6476d8979174f395a1bf784486254464c349d but fixes the existing
 > /etc/inittab file in the postinstall script.

[…]

 > +  * sysvinit.postinst: Fix getty path in /etc/inittab on Hurd.

	Please note that the GNU Coding Standards recommend to use the
	"file name" term here instead:

--cut: https://www.gnu.org/prep/standards/standards.html --
    Please do not use the term "pathname" that is used in Unix
    documentation; use "file name" (two words) instead.  We use the term
    "path" only for search paths, which are lists of directory names.
--cut: https://www.gnu.org/prep/standards/standards.html --

	(The last component of a file name — that is, a file name
	without the leading directories — could then presumably be
	called "base name.")

[…]

 > +if [ "$(uname)" = GNU ]; then
 > +    sed -i -e 's|/libexec/getty|/sbin/getty|' /etc/inittab

	I don't seem to understand.  Shouldn't it be the other way
	around?

	But overall, I doubt that this change is necessary.  If the
	package is being upgraded, the chances are that this defect was
	already corrected by the user.  And for the new installations,
	wasn't this issue already fixed?

 > +fi
 > +

-- 
FSF associate member #7257

[prev in list] [next in list] [prev in thread] [next in thread]