[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs
From:       Samuel Thibault <samuel.thibault () gnu ! org>
Date:       2011-08-30 20:43:54
Message-ID: 20110830204354.GG5263 () type ! famille ! thibault ! fr
[Download RAW message or body]

Guillem Jover, le Tue 30 Aug 2011 02:43:03 +0200, a écrit :
> If the original file has to be modified anyway to disable the function
> I don't see the point in arbitrarily moving the function somewhere
> else, more so when it forces the function to be global when it should
> be static.

Right.

> I'm following up with a revised version of the patch, which makes it
> easier to track modifications to the original.

Yes, it is better, I have applied it.

Samuel


[prev in list] [next in list] [prev in thread] [next in thread]