[prev in list] [next in list] [prev in thread] [next in thread] 

List:       httpcomponents-commits
Subject:    svn commit: r1698184 - /httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/ht
From:       ggregory () apache ! org
Date:       2015-08-27 15:26:32
Message-ID: 20150827152633.035C7AC000D () hades ! apache ! org
[Download RAW message or body]

Author: ggregory
Date: Thu Aug 27 15:26:32 2015
New Revision: 1698184

URL: http://svn.apache.org/r1698184
Log:
Statement unnecessarily nested within else clause.

Modified:
    httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/MemcachedHttpCacheStorage.java


Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/MemcachedHttpCacheStorage.java
                
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src \
/main/java/org/apache/http/impl/client/cache/memcached/MemcachedHttpCacheStorage.java?rev=1698184&r1=1698183&r2=1698184&view=diff
 ==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/MemcachedHttpCacheStorage.java \
                (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/MemcachedHttpCacheStorage.java \
Thu Aug 27 15:26:32 2015 @@ -253,15 +253,14 @@ public class MemcachedHttpCacheStorage \
i  putEntry(url, updatedEntry);
                     return;
 
+                }
+                final byte[] updatedBytes = serializeEntry(url, updatedEntry);
+                final CASResponse casResult = client.cas(key, v.getCas(),
+                        updatedBytes);
+                if (casResult != CASResponse.OK) {
+                    numRetries++;
                 } else {
-                    final byte[] updatedBytes = serializeEntry(url, updatedEntry);
-                    final CASResponse casResult = client.cas(key, v.getCas(),
-                            updatedBytes);
-                    if (casResult != CASResponse.OK) {
-                        numRetries++;
-                    } else {
-                        return;
-                    }
+                    return;
                 }
             } catch (final OperationTimeoutException ex) {
                 throw new MemcachedOperationTimeoutException(ex);


[prev in list] [next in list] [prev in thread] [next in thread]