[prev in list] [next in list] [prev in thread] [next in thread] 

List:       httpclient-commons-dev
Subject:    [jira] [Created] (HTTPCORE-469) Use ReentrantReadWriteLock in AbstractConnPool
From:       "Matt Nelson (JIRA)" <jira () apache ! org>
Date:       2017-05-18 16:29:04
Message-ID: JIRA.13073190.1495124941000.242568.1495124944206 () Atlassian ! JIRA
[Download RAW message or body]

Matt Nelson created HTTPCORE-469:
------------------------------------

             Summary: Use ReentrantReadWriteLock in AbstractConnPool
                 Key: HTTPCORE-469
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-469
             Project: HttpComponents HttpCore
          Issue Type: Improvement
          Components: HttpCore
            Reporter: Matt Nelson
            Priority: Minor


AbstractConnPool is currently using a {{ReentrantLock}} which has to lock for read \
and write operations. Switching to {{ReentrantReadWriteLock}}[1] and read locks for \
the stats/getters methods would reduce the possibility for instrumentation[1] to \
cause contention. Another option would be {{StampedLock}}[3] if the compile target is \
1.8.

[1] https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/ReentrantReadWriteLock.html
 [2] https://github.com/dropwizard/metrics/blob/v3.2.2/metrics-httpclient/src/main/jav \
a/com/codahale/metrics/httpclient/InstrumentedHttpClientConnectionManager.java#L63-L95
 [3] https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/StampedLock.html




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]