[prev in list] [next in list] [prev in thread] [next in thread] 

List:       httpclient-commons-dev
Subject:    [jira] [Resolved] (HTTPCLIENT-1715) NTLMEngineImpl.Type1Message not thread safe but declared as a co
From:       "Gary Gregory (JIRA)" <jira () apache ! org>
Date:       2016-01-27 8:35:39
Message-ID: JIRA.12934172.1453831310000.222144.1453883739880 () Atlassian ! JIRA
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Gary Gregory resolved HTTPCLIENT-1715.
--------------------------------------
       Resolution: Fixed
         Assignee: Gary Gregory
    Fix Version/s: 5.0 Alpha2
                   4.5.2

Fixed in the 4.5.x branch and in trunk. Please verify and close.

> NTLMEngineImpl.Type1Message not thread safe but declared as a constant
> ----------------------------------------------------------------------
> 
> Key: HTTPCLIENT-1715
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1715
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.5.1
> Reporter: Olivier Lafontaine
> Assignee: Gary Gregory
> Fix For: 4.5.2, 5.0 Alpha2
> 
> 
> {{NTLMEngineImpl}} declares a {{static final}} member named {{TYPE_1_MESSAGE}} of \
> type {{Type1Message}}. Members of {{Type1Message}} are final and do not change, but \
> that is not the case for members of its superclass {{NTLMMessage}}. Whenever the \
> method {{NTLMEngineImpl#getType1Message(String, String)}} is called, the method \
> {{NTLMMessage#getResponse()}} get called on the {{TYPE_1_MESSAGE}} instance and \
>                 this modifies the following members of {{NTLMMessage}}:
> * messageContents
> * currentOutputPosition
> This is not thread safe and we get exceptions as seen in HTTPCLIENT-1686.
> My guess is that the computed response string should be kept in a constant instead \
> of a {{Type1Message}} instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]