[prev in list] [next in list] [prev in thread] [next in thread] 

List:       httpclient-commons-dev
Subject:    [jira] [Resolved] (HTTPCLIENT-1358) MainClientExec Does Too Much
From:       "Oleg Kalnichevski (JIRA)" <jira () apache ! org>
Date:       2013-05-29 14:27:20
Message-ID: JIRA.12649699.1369748704877.34995.1369837640815 () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Oleg Kalnichevski resolved HTTPCLIENT-1358.
-------------------------------------------

    Resolution: Won't Fix

James,
I know that MainClientExec is messy but your patch mostly moves mess from one place \
to another. Now we ended up with two messy classes instead of one. My objection to \
doing that pretty much all new methods are taken completely out of context. Consider \
#resetAuthState for instance. It is applicable to one case and one case only: the use \
of non-persistent connections during authentication. It is absolutely unclear what \
this method is supposed to do and how it is supposed to be used. Making it re-usable \
buys us nothing as because the _only_ place where it is applicable is, well, \
MainClientExec.

I am sorry but I'll close this issue as WONTFIX unless you want to take another stab \
at it.

Oleg
                
> MainClientExec Does Too Much
> ----------------------------
> 
> Key: HTTPCLIENT-1358
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1358
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.3 Beta1
> Reporter: James Leigh
> Priority: Trivial
> Labels: patch
> Fix For: 4.3 Beta2
> 
> Attachments: HTTPCLIENT-1358.patch
> 
> 
> MainClientExec directs the route, establishes connections, handles target \
> authentication and handles proxy authentication. It is involved with both the \
> connection/route management and the authentication semantics. It is currently too \
> hard to intercept/handle httpclient requests without serializing them in a socket \
> first. If the authentication was handled in a different class, then the connection \
> route/timeout management, it would be easier to provide custom handling on the \
> client side using the complete request (including auth headers).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]