[prev in list] [next in list] [prev in thread] [next in thread] 

List:       httpclient-commons-dev
Subject:    Re: Use of TestAll classes in HttpClient - some test cases are
From:       Oleg Kalnichevski <olegk () apache ! org>
Date:       2008-10-26 20:12:32
Message-ID: 1225051952.15262.11.camel () ubuntu
[Download RAW message or body]

On Sun, 2008-10-26 at 18:00 +0000, sebb wrote:
> The test cases for HttpClient are created by running only the umbrella
> TestAll class, and ignoring all other classes in the test hierarchy.
> This seems to me a risky way of doing the tests, as it is very easy to
> forget to add a new test class to the TestAll class.
> 
> For example, org.apache.http.client.protocol.TestUriEscapes is not
> exercised by the org.apache.http.client.protocol.TestAllProtocol
> class, and the org.apache.http.client.utils.TestAllUtils umbrella
> class is not included in the TestAll class. I've not checked every
> test class, just did a cursory check.
> 
> I'd like to suggest getting rid of all such classes, and changing the
> pom to pick up all classes instead. I cannot myself see any advantage
> in having these test umbrella classes.
> 

+1 to that.

> However, if there is a good reason to keep them, then the pom should
> run the tests from everything *except* the TestAll* classes by
> default; the Test* classes could then still be used to manually run
> partial tests (assuming this can be done in Maven).
> 

TestAll is a hangover from HttpCient 2.0 days when we used to have
online tests requiring a local Tomcat instance. There is no longer any
reason to keep it and similar classes.

Oleg



> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]