[prev in list] [next in list] [prev in thread] [next in thread]
List: htmlunit-develop
Subject: Re: [HtmlUnit] Ownership of HtmlUnitDriver
From: Simon Stewart <simon.m.stewart () gmail ! com>
Date: 2014-08-30 14:40:56
Message-ID: CAOrAhYFZmn5e48cV58FGvfkS9e9y3i=poA7VFESwVK-+8JgNvQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Ronald,
You need the commit bit to push code to the main selenium repo. What we
generally find is that people fork the mirror on GitHub, make their changes
on a branch on that, and then send us a Pull Request, which we then pull
into the main repo.
It sounds complicated, but it's not _that_ bad once you've done it a few
times. Steps would be something like:
1) Visit https://github.com/SeleniumHQ/selenium and hit the "Fork" button
on the top right.
2) Clone your fork locally. It'll be a command like:
git clone https://github.com/yourId/selenium
3) cd selenium
4) Create a branch: git checkout -b branch_name
5) Hack on your work
6) Commit locally, then create a Pull Request via
https://github.com/SeleniumHQ/selenium/pulls
Then give one us a nudge on the #selenium IRC channel on freenode.
If you're interested, we perform the following steps to land your code into
the main tree: https://code.google.com/p/selenium/wiki/CommitterGitWorkflow
One of the interesting things we do is squash all your commits into a
single commit, so our history on the master branch is linear and composed
of logical changes.
Regards,
Simon
On Sun, Aug 3, 2014 at 5:30 PM, Ronald Brill <rbri@rbri.de> wrote:
> >Take the code and fork it, is what I'd suggest. You'll need to leave the
> >selenium project's copyright header in the files, but as you modify them
> >you should add the htmlunit project's name to them too.
>
> Hi Simon,
>
> this is the first time i try to use git, so maybe the question is stupid.
> Have created a local clone of the selenium repo and done my first change.
> Now i like to push the commit to the selenium repo, but this fails. Is
> there some rigth required?
>
> My google user name is rbri@rbri.de
>
> Thanks
> RBRi
>
>
[Attachment #5 (text/html)]
<div dir="ltr">Hi Ronald,<div><br></div><div>You need the commit bit to push code to \
the main selenium repo. What we generally find is that people fork the mirror on \
GitHub, make their changes on a branch on that, and then send us a Pull Request, \
which we then pull into the main repo.</div> <div><br></div><div>It sounds \
complicated, but it's not _that_ bad once you've done it a few times. Steps \
would be something like:</div><div><br></div><div>1) Visit <a \
href="https://github.com/SeleniumHQ/selenium">https://github.com/SeleniumHQ/selenium</a> \
and hit the "Fork" button on the top right.</div> <div>2) Clone your fork \
locally. It'll be a command like:</div><div> git clone <a \
href="https://github.com/yourId/selenium">https://github.com/yourId/selenium</a></div><div>3) \
cd selenium</div><div>4) Create a branch: git checkout -b branch_name</div> <div>5) \
Hack on your work</div><div>6) Commit locally, then create a Pull Request via <a \
href="https://github.com/SeleniumHQ/selenium/pulls">https://github.com/SeleniumHQ/selenium/pulls</a></div><div><br></div><div>Then \
give one us a nudge on the #selenium IRC channel on freenode.</div> \
<div><br></div><div>If you're interested, we perform the following steps to land \
your code into the main tree: <a \
href="https://code.google.com/p/selenium/wiki/CommitterGitWorkflow">https://code.google.com/p/selenium/wiki/CommitterGitWorkflow</a> \
One of the interesting things we do is squash all your commits into a single commit, \
so our history on the master branch is linear and composed of logical changes.</div> \
<div><br></div><div>Regards,</div><div><br></div><div>Simon</div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 3, 2014 at 5:30 PM, \
Ronald Brill <span dir="ltr"><<a href="mailto:rbri@rbri.de" \
target="_blank">rbri@rbri.de</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="">>Take the code and fork it, is what I'd \
suggest. You'll need to leave the<br> >selenium project's copyright header \
in the files, but as you modify them<br> >you should add the htmlunit \
project's name to them too.<br> <br>
</div>Hi Simon,<br>
<br>
this is the first time i try to use git, so maybe the question is stupid.<br>
Have created a local clone of the selenium repo and done my first change.<br>
Now i like to push the commit to the selenium repo, but this fails. Is there some \
rigth required?<br> <br>
My google user name is <a href="mailto:rbri@rbri.de">rbri@rbri.de</a><br>
<br>
Thanks<br>
RBRi<br>
<br>
</blockquote></div><br></div>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
HtmlUnit-develop mailing list
HtmlUnit-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic