[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hostap
Subject:    Re: [PATCH 04/18] MLD STA: Add support to fetch MLO connection info to wpa_s
From:       Jouni Malinen <j () w1 ! fi>
Date:       2022-08-31 19:40:33
Message-ID: 20220831194033.GA446876 () w1 ! fi
[Download RAW message or body]

On Thu, Jul 28, 2022 at 07:15:33PM +0530, Veerendranath Jakkam wrote:
> Add support to fetch MLO connection info from driver to wpa_s instance
> of corresponding MLD STA interface.

> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> +static void wpa_supplicant_update_link_bss(struct wpa_supplicant *wpa_s,

> +	if (bss)
> +		wpa_s->links[link_id].bss = bss;

This looks suspicious since the bss entry could be removed from memory
and the links[].bss could become stale. If I understood correctly, patch
5/18 is protecting against this. If that is correct, that patch should
likely be moved to be before this patch 4/18. Or if that cannot be done
due to some dependencies, these patches may need to be merged into a
single one.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/hostap
[prev in list] [next in list] [prev in thread] [next in thread]