[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hostap
Subject:    Re: [PATCH v3 00/15] mesh: enable DFS channels in mesh mode
From:       Masashi Honma <masashi.honma () gmail ! com>
Date:       2018-05-30 1:03:42
Message-ID: 65eaa21e-e1db-3e64-d555-87e246362a6e () gmail ! com
[Download RAW message or body]

On 2018/05/30 06:45, Peter Oh wrote:
> Hi,
>
>>
> I've sent a new patchset including your changes except memory leak below.
>>
>>
>> And a memory leak should be fixed like this.
>>
>>
>> diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
>> index 67519fe..ca62b1a 100644
>> --- a/wpa_supplicant/mesh.c
>> +++ b/wpa_supplicant/mesh.c
>> @@ -439,6 +439,7 @@ int wpa_supplicant_join_mesh(struct 
>> wpa_supplicant *wpa_s,
>>
>>         if (!ssid || !ssid->ssid || !ssid->ssid_len || 
>> !ssid->frequency || !params) {
>>                 ret = -ENOENT;
>> +               os_free(params);
>>                 goto out;
>>         }
>>
> can you send a patch for it, since it's different from dfs change?
No, this is caused by your patches. Current wpa_supplicant does not have 
this memory leak.
Please include this fix in your patch set because Jouni does not want to 
merge patch set
which has known memory leak.

Regards,
Masashi Honma.

_______________________________________________
Hostap mailing list
Hostap@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/hostap

[prev in list] [next in list] [prev in thread] [next in thread]