[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hostap
Subject:    Re: [PATCH] l2_packet: fix eloop leak when using l2_packet_none
From:       Jouni Malinen <j () w1 ! fi>
Date:       2014-04-14 20:09:48
Message-ID: 20140414200948.GA11787 () w1 ! fi
[Download RAW message or body]

On Mon, Apr 14, 2014 at 01:48:42PM +0200, Maxime Bizon wrote:
> if you don't have CONFIG_L2_PACKET=y, it happens to use l2_packet_none
> implementation automatically
> 
> I don't have CONFIG_RSN_PREAUTH so it is not selected automatically
> 
> the code looked more to me like a "do nothing" layer instead of a
> reference implementation

Ah, I see. Somehow I did not even remember this being a possibility
anymore since l2_packet is used in number of places and wpa_supplicant
uses l2_packet_linux.c by default. Anyway, I see now that this is not
the case for hostapd.

> I've not tested this, but since my eloop patch was applied (assert(fd !=
> -1)), usage of l2_packet_none should not be possible anymore.
> 
> maybe we should leave l2_packet_none as-is or rename it and use empty
> static inline functions when we don't need it ?

It's fine to just skip the eloop_register_read_sock() call while leaving
the example there. I'll fix this.
 
-- 
Jouni Malinen                                            PGP id EFC895FA
_______________________________________________
HostAP mailing list
HostAP@lists.shmoo.com
http://lists.shmoo.com/mailman/listinfo/hostap
[prev in list] [next in list] [prev in thread] [next in thread]