[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hostap
Subject:    Re: [PATCH] nl80211:  Increase verbosity for some auth failures.
From:       Jouni Malinen <j () w1 ! fi>
Date:       2012-12-23 9:51:07
Message-ID: 20121223095107.GA4261 () w1 ! fi
[Download RAW message or body]

On Thu, Dec 13, 2012 at 09:29:23AM -0800, greearb@candelatech.com wrote:
> Makes the logs a bit more useful when running in default
> message level (INFO).

Since these are wpa_dbg() and not wpa_printf() calls, these would show
up in wpa_cli and especially the (auth) one shows up in common cases due
to cfg80211 behavior ("Operation already in progress"). As such, these
would result in undesired entries in wpa_cli and other programs using
control interface. Furthermore, these should be wpa_msg() instead of
wpa_dbg() after the change to MSG_INFO. Anyway, I don't think I would
apply this because of the way too common entries these would show in
external programs for cases that are expected behavior with at least
older versions of cfg80211.

-- 
Jouni Malinen                                            PGP id EFC895FA
_______________________________________________
HostAP mailing list
HostAP@lists.shmoo.com
http://lists.shmoo.com/mailman/listinfo/hostap
[prev in list] [next in list] [prev in thread] [next in thread]