[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-dev
Subject:    Re: [dev] [commits] Horde branch master updated. 3d9b980a85453ab10074a3e7cafecb0efb0fc13e
From:       Michael M Slusarz <slusarz () horde ! org>
Date:       2013-09-30 20:52:42
Message-ID: 20130930145242.Horde.bGRb0F7lg9jKDtNH-GJfiA1 () bigworm ! curecanti ! org
[Download RAW message or body]

Quoting "Michael J. Rubinsky" <mrubinsk@horde.org>:

> commit 86ac160f9919a26b7483309594723497587cafb3
> Author: Michael J Rubinsky <mrubinsk@horde.org>
> Date:   Sun Sep 29 18:15:23 2013 -0400
>
>     Add Horde_Stream::read
>
>  framework/Stream/lib/Horde/Stream.php |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>
> http://github.com/horde/horde/commit/86ac160f9919a26b7483309594723497587cafb3
> http://git.horde.org/horde-git/-/commit/86ac160f9919a26b7483309594723497587cafb3

No -- this is already handled by getString() so this is entirely  
duplicative.  Plus this isn't charset capable (getString() will be...  
I just haven't committed that code yet).

> commit f431345e62e2488861d563a8e98c733cca677add
> Author: Michael J Rubinsky <mrubinsk@horde.org>
> Date:   Sun Sep 29 18:18:15 2013 -0400
>
>     Fix calling Horde_Stream::add with Horde_Stream that is larger  
> than 65536 bytes.
>
>  framework/Stream/lib/Horde/Stream.php |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> http://github.com/horde/horde/commit/f431345e62e2488861d563a8e98c733cca677add
> http://git.horde.org/horde-git/-/commit/f431345e62e2488861d563a8e98c733cca677add

This is partially due to the usage of stream_get_contents() and  
partially due to ambiguities in the getString() documentation.  Fixed.

michael

___________________________________
Michael Slusarz [slusarz@horde.org]

-- 
dev mailing list
Frequently Asked Questions: http://wiki.horde.org/FAQ
To unsubscribe, mail: dev-unsubscribe@lists.horde.org
[prev in list] [next in list] [prev in thread] [next in thread]