[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-dev
Subject:    Re: [dev] [commits] Horde branch master updated.
From:       Jan Schneider <jan () horde ! org>
Date:       2011-10-28 13:40:36
Message-ID: 20111028154036.Horde.p7aKMRPcj3hOqrDUO93FfvA () neo ! wg ! de
[Download RAW message or body]


Zitat von Ben Klang <bklang@horde.org>:

> On Oct 20, 2011, at 3:55 AM, Jan Schneider wrote:
>
>>
>> Zitat von Ben Klang <ben@alkaloid.net>:
>>
>>> The branch "master" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: 56eee7c847059f594e66932a34ad9b4002c8dc2e
>>>
>>> 2e5ec57 Fix reading the user object from LDAP
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit 2e5ec57fb23a5a5e42dc10be6d7b58113f500477
>>> Author: Ben Klang <bklang@horde.org>
>>> Date:   Wed Oct 19 13:23:31 2011 -0400
>>>
>>>    Fix reading the user object from LDAP
>>>
>>> passwd/lib/Driver/Ldap.php |    3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> http://git.horde.org/horde-git/-/commit/2e5ec57fb23a5a5e42dc10be6d7b58113f500477
>>
>> This doesn't look right. Why would replacing configurable values  
>> with hardcoded values fix anything? And wouldn't it break things  
>> for people that have LDAP configured differently than you? Also,  
>> what are you actually trying to fix?
>>
> Actually I'm pretty sure this is correct.  The problem I was  
> experiencing is that the previous search was not returning any  
> record.  The purpose of the search I modified is to return exactly  
> one LDAP object, that of the account whose password is being  
> changed.  By changing the scope to "base" the Horde_Ldap library  
> will execute an ldap_read() instead of ldap_search().  This is a  
> good thing since we already know the full DN.  The documentation for  
> ldap_read() states that you cannot have an empty search filter. We  
> could use the configured filter, but since we already know the full  
> DN there is really no need to do so.  This is explained in the  
> ldap_read() documentation on php.net.

Ah, I completely missed that we already have the DN at that point. In  
that case we don't even need to use search() at all, but can retrieve  
the entry directly. Please test what I just committed.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/

-- 
Horde developers mailing list
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@lists.horde.org
[prev in list] [next in list] [prev in thread] [next in thread]