[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-dev
Subject:    Re: [dev] Horde_RPC_soap tweaks
From:       Chuck Hagenbuch <chuck () horde ! org>
Date:       2007-12-17 21:11:18
Message-ID: 20071217161118.18074u0asck0cl4w () technest ! org
[Download RAW message or body]

Quoting John Morrissey <jwm@horde.net>:

>> Seems like a bug - if there are explicit provides entries, we
>> shouldn't return other methods, right?
>
> Sorry, I wasn't clear. Registry::listMethods() honors provides entries, but
> since it's called with no arguments in Horde_RPC_soap, the provided methods
> for all applications are listed. This makes complete sense for the main
> Horde WSDL, since you want to emit all possible provided methods.

Okay.

>> I think instantiating a limited server is still a useful feature.
>
> I've made the suggestions to date; attached are the updated patches, for
> HEAD and FRAMEWORK_3. Any final thoughts before I commit them?

I would like to see the variables prefixed with $allowed instead of  
$restrict - it's a little clearer that they're then lists of allowed  
things. restrict sounds like a boolean (restrictions are on or off).  
I'd also like to see a @TODO on the globals to remove them when PEAR  
SOAP is fixed or when we move to PHP 5's soap extension - just so it  
doesn't slip past us for years.

Otherwise looks quite good - thank you!

-chuck

-- 
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@lists.horde.org
[prev in list] [next in list] [prev in thread] [next in thread]