[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-dev
Subject:    Re: [dev] [patch] Relative paths in Xinha
From:       Chuck Hagenbuch <chuck () horde ! org>
Date:       2006-01-29 10:31:38
Message-ID: 20060129053138.x414pj0lwo0w4cwk () marina ! horde ! org
[Download RAW message or body]

Quoting Roel Gloudemans <roel@gloudemans.info>:

> Fixed a bug in the patch.
> Also determine the servername with Horde::url as Jan suggested (thanks!)

It didn't look like it hurt to go ahead and commit this, so I did.  
Please update before generating the new plugins patch so this is taken  
into account as necessary.

Btw, Roel, the only thing I've been changing with your patches is  
adding whitespace after commas - we specify ($foo, 'bar'), not  
($foo,'bar'), in our CODING_STANDARDS. If you could do that, I'd just  
apply them as-is. And otherwise very nice work. Thanks!

-chuck

-- 
"So we're talking near-sonic speeds for a vegetable."
Reasons to go to the Punkin Chunkin World Championships

-- 
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@lists.horde.org
[prev in list] [next in list] [prev in thread] [next in thread]