[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-dev
Subject:    Re: [dev] kronolith listEvents
From:       Jan Schneider <jan () horde ! org>
Date:       2005-09-25 16:53:56
Message-ID: 20050925185356.vimqb5wso4484sg8 () neo ! wg ! de
[Download RAW message or body]

Zitat von Karsten Fourmont <fourmont@gmx.de>:

> somewhat redundandt: I propose to change this into an UID => ID array 
> instead. I checked all usages of the driver's listEvents method and 
> the change shouldn't have any side affects. The return value is 
> always only used in the form $a = $k->listEvents() foreach($a as 
> $event), so changing the array _key_ is fine.
>
> The kolab driver listEvents currently returns a numbered array of 
> UIDs (not IDs). To achieve a consistents behaviour, it should be 
> changed,too (see patch).

Did you check if this UID is perhaps used later in the code and 
expected by other Kolab driver methods?

> The mcal driver's listEvents is even different: it creates an array 
> of event objects. Strange. Is this used at all?

We don't even have an mcal driver anymore. Where are you looking?

> Anyhow. Is it OK do commit the attached patch? The kronolith_list 
> function seems to expect the format I propse: with attached patch it 
> returns guids as expected.

If you check the Kolab driver, fine by me.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/


-- 
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@lists.horde.org
[prev in list] [next in list] [prev in thread] [next in thread]