[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-bugs
Subject:    [Tickets #9161] Remove Horde::applicationUrl()
From:       bugs () horde ! org
Date:       2010-07-30 15:45:37
Message-ID: whups-9161-40da5920f32557c0a3e3eec1fb8a2e62 () bugs ! horde ! org
[Download RAW message or body]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9161
------------------------------------------------------------------------------
  Ticket             | 9161
  Created By         | Michael Slusarz <slusarz@horde.org>
  Summary            | Remove Horde::applicationUrl()
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Enhancement
  State              | Accepted
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Michael Slusarz <slusarz@horde.org> (2010-07-30 11:45) wrote:

Zitat von Michael M Slusarz <slusarz@horde.org>:

> Quoting Jan Schneider <jan@horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz@horde.org>:
>>
>>> commit 05f2a53df4b555f1fdaded5213af80fed4bc0907
>>> Author: Michael M Slusarz <slusarz@curecanti.org>
>>> Date:   Fri Jul 9 11:15:14 2010 -0600
>>>
>>>   I *think* we always want Horde::url() to use Horde webroot
>>>
>>>   All of a sudden, I was getting weird redirects to URLs like
>>>   example.com/imp/imp during logins - because webroot was example.com/imp
>>>
>>>   This might be an artifact of new sidebar code (?)
>
> No - this was due to an overzealous optimization I did in Registry.   
>  This has been reverted and fixed.
>
>> No, Horde::url() is supposed to work with the current application,   
>> thus this change is wrong. I think we could get rid off   
>> applicationUrl() completely though, to simplify things.
>
> I guess this begs the question: what the heck is/was   
> applicationUrl() ever useful for?  Because, by your definition,   
> url() and applicationUrl() are entirely duplicative.

url() is returning relative URLs while applicationUrl() is always
returning absolute URLs.

> Not that I mind - since I am for removing applicationUrl() in favor   
> of a single URL generation function to rule them all.

Yes, I think those two methods are overly complicating things.





-- 
You are subscribed to this list as: horde-bugs@progressive-comp.com
To unsubscribe, mail: bugs-unsubscribe@lists.horde.org
[prev in list] [next in list] [prev in thread] [next in thread]