[prev in list] [next in list] [prev in thread] [next in thread] 

List:       horde-bugs
Subject:    [Tickets #3541] NEW: Improper regular expressions for matching
From:       bugs () coyote ! horde ! org
Date:       2006-02-27 9:31:12
Message-ID: 20060227013112.wqx1r9jl4oggssw4 () bugs ! horde ! org
[Download RAW message or body]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3541
-----------------------------------------------------------------------
 Ticket             | 3541
 Created By         | voegelas@gmx.net
 Summary            | Improper regular expressions for matching addresses in \
Horde/UI/VarRenderer/html.php  Queue              | Horde Base
 Version            | 3.1-RC3
 State              | Unconfirmed
 Priority           | 1. Low
 Type               | Bug
 Owners             | 
-----------------------------------------------------------------------


voegelas@gmx.net (2006-02-27 01:31) wrote:

The regular expression ACT|NSW|NT|QLD|SA|TAS|VIC|WA for matching Australian
addresses also matches addresses that contain the text "USA", ie. US
American addresses. I think that the regex should check for word boundaries:
\b(ACT|NSW|NT|QLD|SA|TAS|VIC|WA)\b. Possibly, the regex for UK addresses
should also be updated.

BTW, what about adding comments with example addresses that show what
address style these regular expressions are supposed to match?

The code for European style addresses doesn't seem to match German
addresses. At least, not the address style suggested by the German Post.
Here's an example for national mail:

Muster GmbH                 COMPANY NAME (optional, of course)
Max Mustermann             FIRST NAME followed by LAST NAME
Musterstr. 1a                  STREET or P.O. BOX
12345 Musterhausen       POSTAL CODE followed by CITY NAME

The German postal code must never be prefixed with "D-" although there are
still people who do this. Instead, the country name must be given in German,
French or English on another line. An example for international mail:

John Dundee
Harbour Place 4
CANBERRA ATC 4568
AUSTRALIEN




-- 
You are subscribed to this list as: horde-bugs@progressive-comp.com
To unsubscribe, mail: bugs-unsubscribe@lists.horde.org


[prev in list] [next in list] [prev in thread] [next in thread]