[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-video-dev
Subject:    [Video-dev] Re: [Masf-restricted-dev] Re: CR: fix winnt.h build
From:       Greg Wright <gwright () real ! com>
Date:       2008-02-08 18:09:46
Message-ID: 47AC9AEA.1060506 () real ! com
[Download RAW message or body]

That looks great.

--greg.


Jamie Gordon wrote:
> Actually here is a much simpler fix, which matches what we do everywhere
> else. We still have good ol' hxbasetsd.h which is up-to-date to work
> with the PlatformSDK. The right change is just to include
> "hxclib/windows.h" rather than directly including <windows.h>, in order
> to pull in the right dependencies.
> 
> Jamie Gordon wrote:
>> Synopsis:
>> Fixes build busters in video/sitelib and rt-renderer caused by
>> mismatched headers from MS SDKs
>>
>> Overview:
>> winnt.h and basetsd.h are a nightmare.
>>
>> The Windows PlatformSDK includes basetsd.h that defines POINTER_64 and
>> winnt.h that uses POINTER_64 under the assumption that basetsd.h has
>> already defined it. The versions of these headers that ship with VC 7.1
>> define POINTER_64 in winnt.h instead of basetsd.h (but that's never
>> really a conflict with the PlatformSDK since you will always get both
>> headers from the same place). However, the DirectX 8 SDK also includes
>> a version of basetsd.h that also does not define POINTER_64, but it does
>> not include a matching winnt.h.
>>
>> So if DirectX and Platform SDK includes are both in the include path
>> and DirectX comes first, you get Platform SDK's winnt.h including
>> DirectX's basetsd.h and failing miserably because no one defined
>> POINTER_64.
>>
>> Client builds always pick up Platform SDK via a global umakefil, which
>> gets executed after the module umakefil. So this change just ensures
>> that the Platform SDK includes are added before DirectX SDK includes so
>> we will get everything from Platform SDK.
>>
>>
>> Files Modified:
>> video/sitelib/win.pcf
>> datatype/text/realtext/renderer/win32.pcf
>>
>>
>> Platforms and Profiles Affected:
>> All windows platforms
>>
>> Platforms and Profiles Build Verified:
>> win32-i386-vc7/helix-dtdr-all-defines
>>
>> Branches: hxclient_3_1_0_atlas, HEAD
>>
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Masf-restricted-dev mailing list
> Masf-restricted-dev@lists.helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/masf-restricted-dev


_______________________________________________
Video-dev mailing list
Video-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video-dev
[prev in list] [next in list] [prev in thread] [next in thread]