[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-video-dev
Subject:    [Video-dev] RE: [Clientapps-dev] CR: Helix engine side changes for
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2007-08-13 22:41:04
Message-ID: 00b301c7ddfb$0814d020$e58e17ac () EHYCHED620
[Download RAW message or body]


My comment:

I see you added two methods to IHXSurfaceControl. Once you've
shipped a product with a certain interface, it's generally
bad practice to change the interface. So... a couple of
questions: a) is IHXSurfaceControl a Symbian-specific interface
(it looks like it *is* to me);  b) have any Symbian products shipped
with the current version of IHXSurfaceControl?

Rest looks good.

Eric

=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: clientapps-dev-bounces@helixcommunity.org 
> [mailto:clientapps-dev-bounces@helixcommunity.org] On Behalf 
> Of Praveen.Thimmashetty@nokia.com
> Sent: Monday, August 13, 2007 4:43 PM
> To: clientapps-dev@helixcommunity.org; 
> Datatype-dev@helixcommunity.org; 
> Client-dev@helixcommunity.org; Video-dev@helixcommunity.org; 
> common-dev@helixcommunity.org
> Subject: [Clientapps-dev] CR: Helix engine side changes for 
> optimizing videoaspect ratio to the display aspect ratio
> 
> "Nokia submits this code under the terms of a commercial 
> contribution agreement with RealNetworks, and I am authorized 
> to contribute this code under said agreement."
> 
> Modified by:  praveen.thimmashetty@nokia.com 
> 
> Reviewed by: 
> 
> Date: 13-Aug-2007 
> 
> Project: SymbianMmf_Rel 
> 
> Req ID: 101-30829 
> 
> Synopsis: This requirement adds the support for viewing video 
> in three different modes. 
> 
> 		                Natural: keeping original video 
> aspect (auto up-scaling as today) 
> 		                Zoom: blow up the picture zoom 
> both X and Y direction and crop to fill the screen 
> 
>                 Stretch: stretch bottom/top or left/right to 
> fill the screen 
>                 New Custom Interface has been added to pass 
> Scaling value from client. 
> 
> Files Modified:         client/include/hxsite3.h 
>                 clientapps/symbianMmf/hxmmfsitesupplier.cpp 
>                 clientapps/symbianMmf/hxmmfsitesupplier.h 
>                 
> clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp 
>                 clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.h 
>                 
> common/system/platform/symbian/symbianglobalvideoparameters.cpp 
>                 
> common/system/pub/platform/symbian/symbianglobalvideoparameters.h 
>                 datatype/mdf/video/renderer/mdfvideoadapter.cpp 
>                 datatype/mdf/video/renderer/pub/mdfvideoadapter.h 
>                 video/sitelib/platform/symbian/minisymbiansite.cpp 
>                 video/sitelib/pub/platform/symbian/minisymbiansite.h 
> 
> Files Added: 
>                         
> common/system/pub/platform/symbian/MMFScalingCustomCommandConstants.h 
> 
> ====================================================== 
> Image Size and Heap Use impact: minor 
> 
> Module Release testing (STIF) :  Passed 
> 
> Test case(s) Added  :  None 
> 
> Memory leak check performed : Yes.  No new leaks introduced.  
> 
> Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-arm 
> 
> Platforms and Profiles Functionality verified: armv5, winscw 
> 
> Branch: Head & 210CayS 
> 
> <<src.zip>> <<diff.txt>> 
> 
> 


_______________________________________________
Video-dev mailing list
Video-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video-dev

[prev in list] [next in list] [prev in thread] [next in thread]