[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-video-dev
Subject:    Re: [Video-dev] CR-Client: OS X Better search for
From:       "Greg Wright" <gwright () real ! com>
Date:       2004-04-12 17:15:44
Message-ID: 0e0901c420b1$cb436b70$ff8317ac () gwright5
[Download RAW message or body]

Don't know anything about the compression manager but
the changes look good to me structurally.

--greg.


----- Original Message ----- 
From: "Bob Clark" <bobclark@real.com>
To: <video-dev@lists.helixcommunity.org>
Sent: Friday, April 09, 2004 5:19 PM
Subject: [Video-dev] CR-Client: OS X Better search for hardware-acceleratedcomponent


> Synopsis:
>    While searching for an OS component to accept YUV data for blitting, 
> it should prefer a component that supports hardware acceleration 
> instead of settling for software acceleration.
> 
> Overview:
>    The old search for an Image Compression Manager component was not 
> deterministic while searching for a component that claimed it could 
> handle YUV. Sadly, it seems that it generally found a software-only 
> component before it found the component that manages hardware 
> acceleration.
>    By adding to the search criteria a manufacturer code of 'appx' we'll 
> be able to focus on a component that supports hardware acceleration.
>    (This is a followup to March 30's cleanup.)
> 
> File Changed:
>    video/sitelib/platform/mac/macsurf.cpp
> 
> Branches:
>    head
>    hxclient_1_1_6_neptune
>    hxclient_1_2_2_neptune
> 
> 
> Index: macsurf.cpp
> ===================================================================
> RCS file: /cvsroot/video/sitelib/platform/mac/macsurf.cpp,v
> retrieving revision 1.5.12.1.2.1
> diff -u -w -r1.5.12.1.2.1 macsurf.cpp
> --- macsurf.cpp 30 Mar 2004 18:58:05 -0000 1.5.12.1.2.1
> +++ macsurf.cpp 10 Apr 2004 00:21:28 -0000
> @@ -908,7 +908,7 @@
> 
>       cd.componentType = 'imdc';
>       cd.componentSubType = 'yuvs';
> -    cd.componentManufacturer = 0;
> +    cd.componentManufacturer = 'appx'; // Apple's component for 
> accelerated hardware
> 
>       cd.componentFlags = 0;
>       cd.componentFlagsMask = 0;
> @@ -918,6 +918,23 @@
>           HX_ASSERT(foundComponent == NULL);
>           foundComponent = c;
>           break;
> +    }
> +
> +    if (!foundComponent)
> +    {
> +        cd.componentType = 'imdc';
> +        cd.componentSubType = 'yuvs';
> +        cd.componentManufacturer = 0; // accept any manufacturer code, 
> including non-accelerated
> +
> +        cd.componentFlags = 0;
> +        cd.componentFlagsMask = 0;
> +
> +        while ((c = FindNextComponent(c, &cd)) != 0)
> +        {
> +            HX_ASSERT(foundComponent == NULL);
> +            foundComponent = c;
> +            break;
> +        }
>       }
> 
>       // this chunk o' code assumes local coordinates.
> 
> 
> _______________________________________________
> Video-dev mailing list
> Video-dev@lists.helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/video-dev


[prev in list] [next in list] [prev in thread] [next in thread]