[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-video-dev
Subject: Re: [Video-dev] CR:New Platform WinCE 4.20 on x86
From: Rishi Mathew <rmathew () real ! com>
Date: 2004-04-07 18:53:15
Message-ID: 6.0.0.22.2.20040407115224.01c27e30 () mailone ! real ! com
[Download RAW message or body]
All approved changes committed to HEAD and hxclient_1_3_0_neptunex
Thanks,
Rishi.
At 06:54 PM 4/6/2004, Kevin Ross wrote:
>Other than Greg's suggestions, I don't see anything glaring, especially
>since I haven't used DirectDraw on WinCE. So, looks good!
>
>-- Kevin
>
>At 01:53 PM 4/5/2004, Greg Wright wrote:
>>+#include "hxassert.h"
>>+
>>+#if defined(_WINCE) && (_WIN32_WCE >= 400)
>>+#include "print.h"
>>+#endif
>>
>>
>>is there anything left that uses print.h? If not, just
>>get rid of it.
>>
>>
>>
>>+ HX_TRACE( "CDDBlt::CreateSurface: CreateSurface successfully created
>>Primary and Offscreen surfaces!\n");
>>
>>
>>I would remove that, its just noise.
>>
>>
>>
>>+#ifndef HELIX_FEATURE_DD_AUTOPIXELFORMAT
>> ddsd.dwFlags |= DDSD_PIXELFORMAT;
>> ddsd.ddpfPixelFormat.dwSize = sizeof(DDPIXELFORMAT);
>>+#endif //!HELIX_FEATURE_DD_AUTOPIXELFORMAT
>> ...
>> ...
>> ...
>>+#if defined(_WINCE) && (_WIN32_WCE >= 400)
>>+ flags[nOutputTypes] = DDPF_RGB|DDPF_ALPHAPREMULT|DDPF_ALPHAPIXELS;
>>+#else
>> flags[nOutputTypes] = DDPF_RGB;
>>-
>>+#endif //(_WINCE) && (_WIN32_WCE >= 400)
>>
>>
>>Instead of using "+#if defined(_WINCE) && (_WIN32_WCE >= 400)" above
>>it looks like we can just use that new HELIX_FEATURE_DD_AUTOPIXELFORMAT
>>can't we?
>>
>>
>>
>>This is a bit redundant:
>>
>>+ if (!m_pPrimary || !m_pOffscreen)
>>+ {
>>+ if (!m_pPrimary)
>>+ if (!m_pOffscreen)
>>+ return HXR_FAIL;
>>+ }
>>+
>>
>>Just make it
>>
>>if( !m_pPrimary && !m_pOffscreen )
>> return HXR_FAIL;
>>
>>
>>Kevin, can you take a quick look at the diff in the video-dev list
>>and make sure you don't see anything strange as well?
>>
>>If Kevin doesn't find anything strange I think it looks good for
>>check-in.
>>
>>--greg.
>>
>>
>>
>>
>>
>>----- Original Message -----
>>From: "Rishi Mathew" <rmathew@real.com>
>>To: "Greg Wright" <gwright@real.com>; <video-dev@lists.helixcommunity.org>
>>Cc: "Mike Frazier" <mfrazier@real.com>
>>Sent: Monday, April 05, 2004 1:35 PM
>>Subject: Re: [Video-dev] CR:New Platform WinCE 4.20 on x86
>>
>>
>> > Ok, I have removed the STDERR msgs..I am attaching the diff..
>> >
>> > ok for checkin?
>> >
>> > -Rishi.
>> >
>> > At 12:41 PM 4/5/2004, Greg Wright wrote:
>> > >Looks good, but since the people sending in the changes don't
>> > >seem to care, lets just get rid of all of the STDERR debug
>> > >messages. Kind of clutters up the code and can easily be
>> > >added in the future if needed.
>> > >
>> > >--greg.
>> > >
>> > >
>> > >----- Original Message -----
>> > >From: "Rishi Mathew" <rmathew@real.com>
>> > >To: "Greg Wright" <gwright@real.com>;
>> <video-dev@lists.helixcommunity.org>
>> > >Cc: "Mike Frazier" <mfrazier@real.com>
>> > >Sent: Friday, April 02, 2004 4:42 PM
>> > >Subject: Re: [Video-dev] CR:New Platform WinCE 4.20 on x86
>> > >
>> > >
>> > > > Greg,
>> > > >
>> > > > I have changed the ddblt.cpp file to make the STDERR msgs
>> exculsive to
>> > > this
>> > > > platform. All other files will remain the same...
>> > > > Also, see inline..
>> > > > At 12:59 PM 3/31/2004, Greg Wright wrote:
>> > > > > > Index: ddblt.cpp
>> > > > > >
>> ===================================================================
>> > > > > > RCS file: /cvsroot/video/sitelib/platform/win/ddblt.cpp,v
>> > > > > > retrieving revision 1.3
>> > > > > > diff -u -w -r1.3 ddblt.cpp
>> > > > > > --- ddblt.cpp 8 Apr 2003 21:25:17 -0000 1.3
>> > > > > > +++ ddblt.cpp 30 Mar 2004 22:40:10 -0000
>> > > > > > @@ -38,6 +38,19 @@
>> > > > > > #include "hxwintyp.h"
>> > > > > > #include "ddblt.h"
>> > > > > >
>> > > > > > +#include "hxassert.h"
>> > > > > >
>> > > > > > +
>> > > > > > +#if defined(_WINCE) && (_WIN32_WCE >= 400)
>> > > > > > +#include "print.h"
>> > > > >
>> > > > >Where is this print.h located? I see one in the
>> > > > > clientapps/simpleplayer directory but they don't want
>> > > > >to depend on a TLC project.
>> > > >
>> > > > I guess we resolved this by moving print.h to common/dbgtool
>> > > >
>> > > >
>> > > > > > if (hr)
>> > > > > > + {
>> > > > > > + STDERR( "CDDBlt::CreateSurface: DirectDrawCreate failed
>> with error
>> > > > > code 0x%08X!\n", hr);
>> > > > > > return HXR_FAIL;
>> > > > > >
>> > > > >
>> > > > >If all these STDERR and STDOUT macros only serve as debug or
>> informational
>> > > > >printfs, then can we not just use one of our standard ones like
>> DPRINTF
>> > > > >or MLOG.
>> > > >
>> > > > As I said, I am making these STDERR msgs exclusive to Wince4.2 on X86
>> > > > platform..see attached diff
>> > > >
>> > > > > > @@ -200,7 +225,7 @@
>> > > > > > rbm[nOutputTypes] = 0xFF0000;
>> > > > > > gbm[nOutputTypes] = 0x00FF00;
>> > > > > > bbm[nOutputTypes] = 0x0000FF;
>> > > > > > - flags[nOutputTypes] = DDPF_RGB;
>> > > > > > + flags[nOutputTypes] =
>> DDPF_RGB|DDPF_ALPHAPREMULT|DDPF_ALPHAPIXELS;
>> > > > >
>> > > > >Can you explain why these flags where added. Do they need to be
>> > > > >#ifdef'ed? Typically when we BLT to the surface, all the alpha
>> > > > >channel information has been 'consumed' by the basesite. Why do
>> > > > >we want to tell it to use it now. Also, I see this change in the
>> > > > >RGB32 section, not the RGR565 section as is indicated in the diff
>> > > > >notes (typo?).
>> > > >
>> > > > I have made this change also exclusive to the Wince4.2 on X86
>> platform, so
>> > > > that it does not affect Win32 on x86 builds...
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > >Have these changes been tested against a full feature windows build?
>> > > >
>> > > > Yes, I have tested it with the Alphablending content that you
>> provided me
>> > > > with..
>> > > >
>> > > >
>> > > > >--greg.
>> > > >
>> > > >
>> > > > Please approve these changes for checkin...
>> > > >
>> > > > Thanks,
>> > > > Rishi.
>> > > >
>> > > >
>> > > >
>> > > > Rishi Mathew
>> > > > Software Development Engineer
>> > > > Helix Development Support Group
>> > > > RealNetworks, Inc.
>> > > > rmathew@real.com
>> > > > 206.892.6126
>> > > > http://www.helixcommunity.org
>> > > > http://www.realnetworks.com/products/support/devsupport.html
>> > > >
>> > >
>> > >
>> > >----------------------------------------------------------------------
>> ----------
>> > >
>> > >
>> > > > _______________________________________________
>> > > > Video-dev mailing list
>> > > > Video-dev@lists.helixcommunity.org
>> > > > http://lists.helixcommunity.org/mailman/listinfo/video-dev
>> > > >
>> >
>> >
>> > Rishi Mathew
>> > Software Development Engineer
>> > Helix Development Support Group
>> > RealNetworks, Inc.
>> > rmathew@real.com
>> > 206.892.6126
>> > http://www.helixcommunity.org
>> > http://www.realnetworks.com/products/support/devsupport.html
>> >
Rishi Mathew
Software Development Engineer
Helix Development Support Group
RealNetworks, Inc.
rmathew@real.com
206.892.6126
http://www.helixcommunity.org
http://www.realnetworks.com/products/support/devsupport.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic