[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/core core_proc.cpp,1.119,1.120
From:       ryuan () helixcommunity ! org
Date:       2013-06-27 5:55:24
[Download RAW message or body]

Update of /cvsroot/server/engine/core
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv2496/server/engine/core

Modified Files:
	core_proc.cpp 
Log Message:
Synopsis
========
HLXSRV-410 Occasionally, broadcast to server with Helix Push mode will fail to start \
                because of authentication
Branches: SERVER_15_1_0, Head

Reviewer: Anyone

Description
===========
This is a bug introduced in Helix Server 15. When developing 15, there was a bug(bug \
270432), it wished server reject a admin connection if the IP Address accessed the IP \
in 15mins ago, even it had right authentication. This is the root cause for this bug, \
which Server wrongly rejected SLTA/Producer. After discussing, we think the \
requirement of bug 270432 isn't reasonable, since both the user and password are \
recorded in browser side. If a client sends right user name and password, Helix \
Server doesn't have any reason to reject it and require user to re-intput the \
credential again. Besides the bug 410, it also caused some other weird problems, \
revert the codes back.

Files Affected
==============
server-restricted/installer/server/retailservinst.cpp
server/access/auth/bascauth/svrbascauth.cpp
server/access/auth/bascauth/svrbascauth.h
server/access/auth/bascauth/umakefil

Testing Performed
=================
Integration Tests
None






Index: core_proc.cpp
===================================================================
RCS file: /cvsroot/server/engine/core/core_proc.cpp,v
retrieving revision 1.119
retrieving revision 1.120
diff -u -d -r1.119 -r1.120
--- core_proc.cpp	27 Jun 2013 02:48:44 -0000	1.119
+++ core_proc.cpp	27 Jun 2013 05:55:12 -0000	1.120
@@ -1161,11 +1161,6 @@
     proc->pc->named_lock_manager->CreateNamedLock("LiveArchStatusLock");
 
     /*
-     * Add a named lock for admin page authentication
-     */
-    proc->pc->named_lock_manager->CreateNamedLock("BaseauthenticationLock");
-
-    /*
      * Add a named lock for RTMPT session
      */
     proc->pc->named_lock_manager->CreateNamedLock("RTMPTLock");


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]