[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] include sapmgr.h,1.2,1.3
From:       tniu () helixcommunity ! org
Date:       2013-03-26 3:34:10
[Download RAW message or body]

Update of /cvsroot/server/include
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv32669

Modified Files:
	sapmgr.h 
Log Message:




Synopsis
========
This CR fix bug (HLXSRV-155)[SLTA]SLTA has fault if using udp/multicast for transport \
protocol. (http://jira.real.com/browse/HLXSRV-155)

Branch : HEAD 

Suggested Reviewer : Anyone

Description: 
===============
Repro Steps:
Summary:
 [Session Manager]: SLTA has fault if using udp/multicast for transport protocol
 -------------------------------------------------------------------------------------
  Version: servproxyall-022813-19333
 Platform: 
RHEL6
 Description:
 Precondition:
 Has the slta configuration file
 100% Reproducible: Yes
 Repro:
 1. Prepare the slta configuration file, set the protocol as udp/multicast  <List \
Name="BroadcastDistribution">  <Var DebugStatsInterval="5000"/>  <Var \
SourceName="slta"/>  <List Name="Destinations">  <List Name="ExampleName">  <Var \
PathPrefix="/"/>  <Var PortRange="30041-30060"/>  <Var AcquisitionDataInterval="30"/> \
<Var FECLevel="0"/>  <Var SureStreamAware="0"/>  <Var BufferlessTransport="1"/>  <Var \
LocalAddress="192.168.35.87"/>  <Var Address="227.100.1.1"/>  <Var TTL="16"/>  <Var \
ResendSupported="0"/>  <Var Protocol="udp/multicast"/>  <List Name="Security">  <Var \
Type="Basic"/>  <Var Password="hms"/>  </List>  </List>  </List>  </List>  2. Run the \
slta  ./slta.sh -c push_multicast.cfg live ../Content/3gp/meet_h264.3gp

Actual:
slta has fault: 
SLTA Copyright(c) RealNetworks, Inc. 1995-2012, All rights reserved. 
Transmitting file://../Content/3gp/meet_h264.3gp... (05-Mar-2013 14:43:29)
./slta.sh: line 62: 14277 Segmentation fault (core dumped) \
"/var/hms/servproxyall-022813-19333//Bin/slta" $* 

Expected:
slta will work well. 

Root cause:
the pointer m_pStreamDesc is NULL in sapclass.cpp when call DealWithSDPType().

My solution:
Call the member function Init() to initialize pointer m_pStreamDesc.

Files affected:
=========
server/include/sapmgr.h
server/protocol/sap/pub/sapclass.h
server-restricted/broadcast/transport/bcng/send-remote/rembrdcst.cpp
	
Test perform
================
Integration Tests: slta works well.

Platforms Tested: win-x86_64-vc10.

Builds Verified: win-x86_64-vc10.

Performance Tests: N/A.

Leak Tests: None.

QA Hints
========
None.

Index: sapmgr.h
===================================================================
RCS file: /cvsroot/server/include/sapmgr.h,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- sapmgr.h	23 Jan 2003 23:42:59 -0000	1.2
+++ sapmgr.h	26 Mar 2013 03:34:01 -0000	1.3
@@ -127,6 +127,7 @@
      *	    Stop the directory
      */
     STDMETHOD_(BOOL, IsAnnouncerEnabled)    (THIS_) PURE;					    
+    STDMETHOD_(HX_RESULT, Init)    (THIS_ IUnknown* pContext) PURE;	
 };
 
 #endif // _SAPMGR_H_


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]