[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] admin/web/build/mserver config_broad_mpeg2ts_ingress.html, 1.10, 1.11
From:       packard () helixcommunity ! org
Date:       2012-08-29 8:14:40
[Download RAW message or body]

Update of /cvsroot/server/admin/web/build/mserver
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv7462

Modified Files:
	config_broad_mpeg2ts_ingress.html 
Log Message:
Synopsis:
=========
fix for Bug 270634:     [MPEG2-TS ingress]: Conflict with other feature's ports \
succeeds without warning 

Branch: SERVER_15_0_RN, HEAD

Suggested Reviewers:  Xiaocheng Li, Richard, Anyone

Description:
=========
Bug summary: When a mpeg2-ts ingress source uses a port range conflicting with other \
features, the server gives no warning but succeeds.


Solution
=========
adding port conflict checking just like other admin page features.


File Affected
=========
server/admin/web/src/srvprxy/config_broad_mpeg2ts_ingress.html.wasm
server/admin/web/build/server/config_broad_mpeg2ts_ingress.html
server/admin/web/build/mserver/config_broad_mpeg2ts_ingress.html



Testing Performed:
================
test with admin page, it could point out the conflict with other features.


QA Hints
========
None.


Index: config_broad_mpeg2ts_ingress.html
===================================================================
RCS file: /cvsroot/server/admin/web/build/mserver/config_broad_mpeg2ts_ingress.html,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -d -r1.10 -r1.11
--- config_broad_mpeg2ts_ingress.html	19 Aug 2012 08:39:44 -0000	1.10
+++ config_broad_mpeg2ts_ingress.html	29 Aug 2012 08:14:32 -0000	1.11
@@ -65,10 +65,10 @@
     new PropObj('StreamTimeout', "5", false, true, 1, 99999, "int", "Stream Timeout" \
),     ];
 
-initAllPortsList( serverData);
 var propList = new PropList( "MPEG2TS_Ingress", mpeg2tsingress, propSetMain, \
propSetSources);  var propFSList = new PropList('MPEG2TS_Mount_Point', mptsfs , \
propFS, null);  
+initAllPortsList( serverData, "MPEG2TS_Ingress" );
 function MPEG2TSIngressPropView ()
 {
     this.base = NestedPropListView ;
@@ -119,6 +119,7 @@
     upper1 = getCtrlValue( theForm.PortRange1 )
     var conflict = 0;
     var subList = this.getSubList();
+    var errMsg = "port range can't overlap with other nodes";
     function checkMptsPortConflict( otherSubList, prop )
     {
         // don't compare this sublist with itself
@@ -128,12 +129,21 @@
 	{
 	    conflict = 1;
 	}				
+	if( conflict == 0 )
+	{
+		conflict = findPortConflictName( 
+				lower1, 
+				upper1 );
+		if ( conflict )
+		{
+			errMsg = getConflictErrMsg( conflict, "MPEG2 TS INGRESS Port Range" ) ;
+		}
+	}
     }
     propList.propSearch( "PortRange", checkMptsPortConflict );
     if ( conflict )
     {
-	this.errMsg = "port range can't overlap with other nodes";
-	return rejectInput( theForm["PortRange0"], this.errMsg );
+	return rejectInput( theForm["PortRange0"], errMsg );
     }
     setCtrlValue( theForm.PortRange, 
 		( ("" == getCtrlValue( theForm.PortRange0 )) ? "" :


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]