[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/core _main.cpp,1.211,1.212
From:       dcollins () helixcommunity ! org
Date:       2012-01-31 2:37:30
[Download RAW message or body]

Update of /cvsroot/server/engine/core
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv25349/server/engine/core

Modified Files:
	_main.cpp 
Log Message:
Synopsis
========
Fixes 270160: Broadcast Distribution "Lost Upstream" stat in RSS is
              reporting cumulative numbers

Branches: SERVER_14_3_RN, SERVER_CURRENT_RN (HEAD)
Reviewer: Chytanya


Description
===========

While debugging bug 270156 it was noted that the Lost Upstream stat
for bdstplin was behaving in a cumulative manner, unlike the other
related stats.  This behavior was recently noted in email from QA.

The fix is to calculate this stat like most of the other stats, taking
a difference between the current value and the previous value.


Files Affected
==============

server/engine/core/_main.cpp


Testing Performed
=================

Unit Tests:
- N/A

Integration Tests:
- Tested as part of 270156 with 100 RTP ingress and 100 RBS ingress
  feeeds, both of which periodically experienced loss.

Leak Tests:
- N/A

Performance Tests:
- N/A

Platforms Tested: linux-rhel5-x86_64
Builds Verified: linux-rhel5-x86_64


QA Hints
========
* N/A


Index: _main.cpp
===================================================================
RCS file: /cvsroot/server/engine/core/_main.cpp,v
retrieving revision 1.211
retrieving revision 1.212
diff -u -d -r1.211 -r1.212
--- _main.cpp	23 Dec 2011 08:24:46 -0000	1.211
+++ _main.cpp	31 Jan 2012 02:37:26 -0000	1.212
@@ -3526,6 +3526,10 @@
     {
         UINT32 uBytesSent;
         UINT32 uPacketsSent;
+        UINT32 uLostUpstream;
+        UINT32 uBufferOverruns;
+        UINT32 uResendsHonored;
+        UINT32 uResendsRequested;
 
         BdstStatistics* bs = pServerInfo->m_pBroadcastDistStats;
 
@@ -3533,6 +3537,14 @@
                                                      bs->m_uPacketsSent);
         uBytesSent = ServerInfo::CounterDifference(&(m_LastBdstStats.m_uBytesSent),
                                                    bs->m_uBytesSent);
+        uLostUpstream = \
ServerInfo::CounterDifference(&(m_LastBdstStats.m_uLostUpstream), +                   \
bs->m_uLostUpstream); +        uBufferOverruns = \
ServerInfo::CounterDifference(&(m_LastBdstStats.m_uBufferOverruns), +                 \
bs->m_uBufferOverruns); +        uResendsHonored = \
ServerInfo::CounterDifference(&(m_LastBdstStats.m_uResendsHonored), +                 \
bs->m_uResendsHonored); +        uResendsRequested = \
ServerInfo::CounterDifference(&(m_LastBdstStats.m_uResendsRequested), +               \
bs->m_uResendsRequested);  
         scale = uBytesSent * 8.0 / timediff / 1000.0;
 
@@ -3543,10 +3555,10 @@
             scale,
             (unsigned long)uPacketsSent);
         pBufPointer += sprintf(pBufPointer, "    Broadcast Distribution: Resends %lu \
                (Requested %lu), Lost Upstream %lu, Dropped %lu\n",
-            (unsigned long)bs->m_uResendsHonored,
-            (unsigned long)bs->m_uResendsRequested,
-            (unsigned long)bs->m_uLostUpstream,
-            (unsigned long)bs->m_uBufferOverruns);
+            (unsigned long)uResendsHonored,
+            (unsigned long)uResendsRequested,
+            (unsigned long)uLostUpstream,
+            (unsigned long)uBufferOverruns);
     }
     else
     {


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]