[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] protocol/http httpprot.cpp,1.132,1.132.2.1
From:       juanitomoore () helixcommunity ! org
Date:       2011-11-30 19:52:06
[Download RAW message or body]

Update of /cvsroot/server/protocol/http
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv25458

Modified Files:
      Tag: SERVER_14_3
	httpprot.cpp 
Log Message:
Synopsis:
=========
Fix for bug 269995.

Branches: 14_2, 14_3, HEAD

Reviewer: Dean

Description:
============
User script causes a CA. Simply abort if demux pointer is nil.

Files affected
===============
server/protocol/http/httpprot.cpp

Tested
======
Tested with a debug build, I verified that the script no
longer CA's the server.

Leak Tests: None
Performance Tests: N/A

Platforms Tested: linux-rhel5-x86_64
                  
Builds Tested: linux-rhel5-x86_64

QA hints
========
Re-run script to verify CA is now avoided.


Index: httpprot.cpp
===================================================================
RCS file: /cvsroot/server/protocol/http/httpprot.cpp,v
retrieving revision 1.132
retrieving revision 1.132.2.1
diff -u -d -r1.132 -r1.132.2.1
--- httpprot.cpp	21 Nov 2011 02:57:48 -0000	1.132
+++ httpprot.cpp	30 Nov 2011 19:52:03 -0000	1.132.2.1
@@ -976,6 +976,10 @@
                               IHXBuffer* pRequestId, IHXBuffer* pRequestURI,
                               IHXValues* pRequestHeaders)
 {
+    if (!m_pDemux)
+    {
+        return HXR_ABORT;
+    }
     Client* pClient = m_pDemux->GetClient();
 
     HX_RESULT rc = HXR_OK;


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]