[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/core _main.cpp,1.196.2.5,1.196.2.6
From:       juanitomoore () helixcommunity ! org
Date:       2011-06-08 0:42:16
Message-ID: 201106080042.p580gKQk014726 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/core
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv21476

Modified Files:
      Tag: SERVER_14_2
	_main.cpp 
Log Message:
Description: 
============

1) Removing "--gdb" from the --help message as it no longer is an option.
2) Removed a variable from a print developer print message to make it work
   as expected.
3) Restructured a pointer that called "new" to simply instantiate itself...
  (keeps compiler from complaining about an unused variable.).

Bug: 269523 https://rnps.real.com:8443/show_bug.cgi?id=269523
===

Reviewer: dcollins
========

Files affected:  server/engine/core/_main.cpp ==============

Branches:  14_2, HEAD
========

Testing performed:  Basic proxy/server starts up as usual.
=================

Platforms tested: linux-rhel-x86_64 (debug) ================

QA Hints:
=========

Run rmproxy --help or rmserver --help and notice no "--gdb" option.


Index: _main.cpp
===================================================================
RCS file: /cvsroot/server/engine/core/_main.cpp,v
retrieving revision 1.196.2.5
retrieving revision 1.196.2.6
diff -u -d -r1.196.2.5 -r1.196.2.6
--- _main.cpp	15 Feb 2011 00:41:48 -0000	1.196.2.5
+++ _main.cpp	8 Jun 2011 00:42:13 -0000	1.196.2.6
@@ -3503,7 +3503,6 @@
 
         pBufPointer += sprintf(pBufPointer, "    FastFile: %llu KB Cached, "
                         "%llu KB ReadAhead, %llu KB MemUse\n",
-                        (unsigned long long)uFastBytesRead / 1024,
                         (unsigned long long)(uFastBytesRead + uSlowBytesRead) / 1024,
                         (unsigned long long)uInternalBytesRead / 1024,
                         (unsigned long long)uMemUse / 1024);
@@ -4745,7 +4744,6 @@
 "Linux-specific options:\n"
 #ifdef XXX_INTERNAL_FLAGS
 "--nss       --no-segv-syscall\n"
-"--gdb                                   Work properly with gdb\n"
 "--sdt       --shared-descriptor-tables  Share Descriptor Tables among threads\n"
 #if defined(_LONG_IS_64) && defined(_LINUX)
 "--fhm       --force-high-memory         Force memory segment above 4GB\n"
@@ -6436,7 +6434,7 @@
     new OncePerSecond(proc);
 
     // Create RSS Core Report
-    RSSCoreStatsReport* rsscsr = new RSSCoreStatsReport(proc);
+    RSSCoreStatsReport rsscsr(proc);
 
     HXMutexUnlock(g_pServerMainLock);
 


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]