[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/core _main.cpp,1.200,1.201
From:       dcollins () helixcommunity ! org
Date:       2011-02-15 0:41:30
Message-ID: 201102150041.p1F0fEme027135 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/core
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv15898/server/engine/core

Modified Files:
	_main.cpp 
Log Message:
Synopsis
========
A follow-up update related to PR 269115 (CPU core detection on Solaris 10)

Branches: HEAD, SERVER_14_2_RN
Reviewer: Chytanya


Description
===========

The original problem in PR 269115 was running on newer hardware which
we were not detecting correctly, causing the server to launch too many
streamer threads.

The PR was reopened, but the underlying trigger was different.  In this
case, it was running on Solaris 10 Update 1.  This version of Solaris
doesn't support the kstat information which we now use to detect the
number of CPU cores.

This change makes the server print a descriptive error message and exit
if it is unable to detect the number of cores.  The user simply needs
to set StreamerCount in their config file.


Files Affected
==============

server/engine/core/_main.cpp


Testing Performed
=================

Unit Tests:
- N/A

Integration Tests:
- Verified behavior on a Solaris 10 Update 1 box, both with and without
  StreamerCount set.

Leak Tests:
- N/A

Performance Tests:
- N/A

Platforms Tested: sunos-5.10-sparc64
Builds Verified: sunos-5.10-sparc64

QA Hints
========
- The code modified only gets used on Solaris.



Index: _main.cpp
===================================================================
RCS file: /cvsroot/server/engine/core/_main.cpp,v
retrieving revision 1.200
retrieving revision 1.201
diff -u -d -r1.200 -r1.201
--- _main.cpp	7 Feb 2011 21:50:24 -0000	1.200
+++ _main.cpp	15 Feb 2011 00:41:28 -0000	1.201
@@ -3891,7 +3891,17 @@
         fscanf(fd, "%d", &nRet);
     }
     pclose(fd);
+    if (nRet == 0)
+    {
+        printf("The CPU core count was not detected.  Please set StreamerCount in the\n");
+        printf("config file.  This should typically be set equal to the total number\n");
+        printf("of CPU cores available.  See the release notes for more information,\n");
+        printf("or contact your RealNetworks support representative.\n");
+        fflush(0);
+        _exit(1);
+    }
     return nRet;
+
 }
 #endif
 


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]