[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] protocol/http httpprot.cpp,1.115,1.116
From:       ckarusala () helixcommunity ! org
Date:       2011-01-31 17:42:41
Message-ID: 201101311742.p0VHgZxt006681 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/protocol/http
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv8906

Modified Files:
	httpprot.cpp 
Log Message:
Synopsis
========
This CR fixes a HTTP logging issue (no PR)


Branch : SERVER_14_2_RN, HEAD
Suggested Reviewer : Dean


Description:
==========
While debugging something else, I noticed that we are not logging an 
access entry when the GET request is denied due to mountpoint not 
configured under HTTP deliverables. The reason is, in 
HTTPProtocol::handleMsg(HTTPGetMessage* pMsg), when AllowAccess() 
fails, we are responding with "403" but never logging it. Fixed it.


Files Modified
==========
server/protocol/http/httpprot.cpp


Testing Performed
=================
Unit Tests:
- Verified that we are now logging the access entry with "403" code 
when a file is request through HTTP and the mountpoint is not 
configured as HTTP deliverable.



Integration Tests:
- None.


Leak Tests:
- None.


Performance Tests:
- None


Platforms Tested: win-x86_64-vc10
Build Verified: win-x86_64-vc10


Thanks,
Chytanya 


Index: httpprot.cpp
===================================================================
RCS file: /cvsroot/server/protocol/http/httpprot.cpp,v
retrieving revision 1.115
retrieving revision 1.116
diff -u -d -r1.115 -r1.116
--- httpprot.cpp	30 Jan 2011 02:11:11 -0000	1.115
+++ httpprot.cpp	31 Jan 2011 17:42:39 -0000	1.116
@@ -2448,6 +2448,7 @@
         if (SUCCEEDED(sendResponse(pResp)))
            SetStatus(403);
         HX_DELETE(pResp);
+        LogRequest();
         return -1;
     }
 


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]